Repository navigation
Move descriptions, deprecation and title of generated "one of" to the property - #322
Merged
wparad merged 3 commits intoNov 9, 2026
Merged
Conversation
…he property, show constraints only on the type option they apply to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # mocks/multi-type-variants-schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a property has type:
["something", null]or the like it is rendered asone Of. That rendering pushes the description and deprecation down to the individual elements.It also copies constraints to elements which can not have them (require unique items in the screenshot).
This pull request leaves these 3 fields at the property level. And have the child items care for the rest.
If you need to only deprecate so elements of a
one Ofyou need to write it explicitly in the spec. But that is unchanged here.Additional note: In the explicit-one-of example image the integer field got no strike through even though it has deprecated set. That is a different bug, not handled here.
Broken
Fixed