Repository navigation
Render patternProperties in all cases - #321
Merged
wparad merged 3 commits intoNov 9, 2026
Merged
Conversation
…ntyped oneOf, anyOf and allOf options. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wparad
requested changes
Nov 9, 2026
wparad
left a comment
wparad
left a comment
Member
There was a problem hiding this comment.
One small thing and then we are good to merge.
Please remove the mocks, or at the very least move them to the schema-utils test where necessary, although I get the sense the tests are already complete. What you do with them is up to you, but we don't need these mocks like this.
wparad
requested changes
Nov 9, 2026
wparad
left a comment
wparad
left a comment
Member
There was a problem hiding this comment.
The tests that were added should not have been deleted, please add those back.
Contributor
Author
|
Ah, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a patternproperty got into a one of (or other complex child relations) it was not (fully) rendered. This change fixes the rendering.
Example openapi file is in the commit.
Broken
Fixed