Repository navigation
Replace ClipboardJS with the Clipboard API - #572
Merged
Merged
Conversation
The team invite-link copy buttons now use navigator.clipboard.writeText() and confirm with a notification, so the admin bundle no longer ships ClipboardJS and its deprecated queryCommandSupported and execCommand calls. Also drops the deleted BiospexLabelReconcile Lambda from the Lambda docs.
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295.
Copy buttons
The team invite-link buttons on the admin event page (
EventTeamPresenter::teamJoinUrlIcon()) used ClipboardJS, which calls the deprecateddocument.queryCommandSupported()andexecCommand('copy'). ClipboardJS 2.0.11 is its latest version, so updating it wouldn't help.resources/js/admin.jscopies the button'sdata-clipboard-textwithnavigator.clipboard.writeText(), then shows "Copied to clipboard." (or a warning if the browser refuses). ClipboardJS gave no feedback.clipboardpackage and itswindow.ClipboardJSglobal are removed. The button markup is unchanged.admin-appbundle no longer containsqueryCommandSupported.Docs
docs/lambdas.mddropsBiospexLabelReconcile, which was deleted from AWS on 2026-10-17 (#505).Tested locally
tests/Unit/Presenters/EventTeamPresenterTest.php: 8 passed (the markup is unchanged).yarn build, then on a local admin event page: clicking a team's copy button copies its signup link (checked by pasting three links).To verify on development
See #573.