Repository navigation
Tests: wait for the text segment in every IncrementalLayoutTests case - #4
Merged
Merged
Conversation
AppendCost_DoesNotGrowWithParagraphLength failed on main after #2 (Windows, run 39051505730) with "Sequence contains no elements": as the first test in the process, one frame was not enough for the block view to exist. The streamed-break tests already wait; the tail-fade and append-cost cases now do too. Also record the known risk of the per-character fallback cache (it pins whatever Avalonia returned first) and why calling the platform matcher directly is not possible (private API stripped from reference assemblies). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppendCost_DoesNotGrowWithParagraphLengthfailed onmainafter Memory footprint (alpha.18) + Windows CI fixes (alpha.19) #2 (Windows, run 39051505730) withSequence contains no elements: as the first test in the process, one frame was not enough for the block view to exist. The tail-fade and append-cost cases now useSettledSegmentlike the streamed-break tests.AvaloniaLocator.Current/IFontManagerImplmembers.Test plan
dotnet test tests/StreamMark.Avalonia.Testson macOS: 334 passed🤖 Generated with Claude Code