Repository navigation
fix: translate hardcoded Japanese strings in Mermaid component - #612
Open
ieCecchetti wants to merge 1 commit into
Open
ieCecchetti wants to merge 1 commit into
ieCecchetti wants to merge 1 commit into
Conversation
The diagram view title, render error, syntax error and loading text in Mermaid.tsx were hardcoded in Japanese, so every UI language showed them in Japanese. Read them from the message files like other components, with English fallbacks, and add the keys to en.json and ja.json (ja keeps the existing text).
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/components/Mermaid.tsxhad four UI strings hardcoded in Japanese (diagram view title, render error, syntax error message, loading text). They now come from the message files throughuseLanguage(), with English fallbacks, likeAsk.tsxdoes. Newdiagramkeys are added toen.jsonandja.json;ja.jsonkeeps the current Japanese text. Other languages fall back to English until translated.Why
With the UI in English (or any other language), a diagram with a syntax error showed
図表レンダリングエラー/図表に構文エラーがあり、レンダリングできません。, which most users can't read.Testing
npm run build(via the Dockerfile) passes; both JSON files parse.