Repository navigation
Conversation
The repo entry form appended the private-repository access token to the navigation URL's query string, and the Code Viewer forwarded it again to /codemap/file's query string, even though that endpoint never reads a token parameter at all. Either exposes the credential via browser history, shared/copied links, and same-origin script access to the URL, and the second also puts it in proxy/access logs for no functional benefit. Capture the token once on first render (via useRef, so it survives what follows) and then scrub it from the visible URL on mount with history.replaceState. Drop the token entirely from CodeViewer's props and its /codemap/file request, since the backend route never consumes it there. Validated with tsc --noEmit and a full next build.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo entry form appended the private-repository access token to the navigation URL's query string, and the Code Viewer forwarded it again to
/codemap/file's query string, even though that endpoint never reads a token parameter at all. Either exposes the credential via browser history, shared/copied links, and same-origin script access to the URL, and the second also puts it in proxy/access logs for no functional benefit.Captures the token once on first render (via
useRef, so it survives what follows) and then scrubs it from the visible URL on mount withhistory.replaceState. Drops the token entirely fromCodeViewer's props and its/codemap/filerequest, since the backend route never consumes it there.Test plan
npx tsc --noEmit: passes.npx next build: full production build passes.