Repository navigation
Conversation
…file docker-compose-litellm.yml fell back to the fixed, documented credentials litellm_password and sk-1234 for PostgreSQL and the LiteLLM master key whenever LITELLM_DB_PASSWORD/LITELLM_MASTER_KEY were not set, while also publishing both services' ports to the host. An operator who started this profile without an override exposed a database and an LLM-proxy admin API with publicly known credentials. Require both secrets (compose now fails startup with a clear message if either is missing) and bind both ports to loopback only, since they are for local inspection, not for the litellm/deepwiki containers (which reach each other over the compose network) or the public internet. litellm-config.yml now reads the database URL from the DATABASE_URL env var built from the same required secret, instead of repeating a hardcoded credential. Validated with : fails with a clear error when the secrets are unset, and resolves correctly (including the loopback port bindings) once they are provided.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-compose-litellm.ymlfell back to the fixed, documented credentialslitellm_passwordandsk-1234for PostgreSQL and the LiteLLM master key wheneverLITELLM_DB_PASSWORD/LITELLM_MASTER_KEYwere not set, while also publishing both services' ports to the host. An operator who started this profile without an override exposed a database and an LLM-proxy admin API with publicly known credentials.Requires both secrets (compose now fails startup with a clear message if either is missing) and binds both ports to loopback only, since they are for local inspection, not for the litellm/deepwiki containers (which reach each other over the compose network) or the public internet.
litellm-config.ymlnow reads the database URL from theDATABASE_URLenv var built from the same required secret, instead of repeating a hardcoded credential.Test plan
docker compose -f docker-compose-litellm.yml config: fails with a clear error when the secrets are unset.LITELLM_DB_PASSWORD/LITELLM_MASTER_KEYset: resolves correctly, including the loopback port bindings and the builtDATABASE_URL.