Repository navigation
Conversation
OpenRouterClient.acall logged the entire api_kwargs (the full prompt, including repository source embedded in it) and the entire provider response at INFO. The application's default logging configuration writes INFO-level logs to a rotating file the deployment persists on disk, so any principal with log access gained the full source context and conversation content for every OpenRouter-backed request. Log only sizing/model metadata (model name, message count and total character length, response status, choice count, token usage) instead of the payload/response content. Adds a regression test in tests/unit/test_openrouter_logging.py, including fail-before coverage run against the unpatched code.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenRouterClient.acalllogged the entireapi_kwargs(the full prompt, including repository source embedded in it) and the entire provider response at INFO. The application's default logging configuration writes INFO-level logs to a rotating file the deployment persists on disk, so any principal with log access gained the full source context and conversation content for every OpenRouter-backed request.Logs only sizing/model metadata (model name, message count and total character length, response status, choice count, token usage) instead of the payload/response content.
Test plan
pytest tests/unit/test_openrouter_logging.py: new regression test passes, asserting the planted secret strings never appear in any log record.