Repository navigation
Conversation
iterate_files() walked a repository with Path.rglob() and called is_file(), which follows symlinks, with no is_symlink() guard. A repository containing a symlink pointing outside the clone (to any file the server process can read) would have that symlink listed alongside real files, and the RAG indexer's open() on it dereferences straight to the external target, embedding and persisting its content. Skip any symlink encountered during the walk instead of following it. Adds a regression test in tests/test_config.py, including fail-before coverage run against the unpatched code.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iterate_files()walked a repository withPath.rglob()and calledis_file(), which follows symlinks, with nois_symlink()guard. A repository containing a symlink pointing outside the clone (to any file the server process can read) would have that symlink listed alongside real files, and the RAG indexer'sopen()on it dereferences straight to the external target, embedding and persisting its content.Skips any symlink encountered during the walk instead of following it.
Test plan
pytest tests/test_config.py: new regression test passes.pytest tests/: full suite passes with no regressions.