Repository navigation
[REFACTOR] Lay out the code by the architecture rules and lint it in CI - #132
Merged
Merged
Conversation
The checker has no luckperms or interceptor word, flags in-memory implementation tests as implementations, and reads a root util as the model's own level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lays the code out by the architecture rules in
.claude/docs, as AstraRating did: link storage leavesdaoand implementations are named by technology, granting and revoking the linked Discord role are use cases, and the Discord contractslinkneeds live inmessenger/api. LuckPerms is reached through a newintegration-luckpermsunit. Every module applies the gradle-plugin linter 2.9.1 with no baseline, and pull requests get anarchitectureCheckjob.Bridged messages, commands, config and translations behave as before; some logger tags follow the class renames. Version 0.38.1.
To check on a server: link an account, see the LuckPerms group and Discord role granted and revoked on unlink, bridge a message both ways from Discord and Telegram, reply to a long message.