Repository navigation
[FIX] Revoke LuckPerms role on unlink and log grant failures - #129
Merged
Merged
Conversation
…them LuckPerms' modifyUser() returns a future that failed silently when, for example, the configured group name was invalid: the role never applied and nothing told the admin why.
/unlink only deleted the link row, so the granted LuckPerms group stuck around after unlinking.
InheritanceNode.builder(String) resolves LuckPerms through its own global static singleton instead of the LuckPermsProvider this plugin already injects for exactly that purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlinking a player now revokes the LuckPerms group granted on link;
/unlinkpreviously only deleted the database row and the group stuck around.Granting or revoking the LuckPerms group also logs the failure when LuckPerms rejects it (for example an invalid group name), instead of silently doing nothing. That path also stopped going through LuckPerms' own global singleton to build the group node, and now reuses the
LuckPermsinstance already resolved through this plugin'sLuckPermsProvider.Version 0.36.1.
Closes #81.