[ji-huazhong]

Wait for captured master processes to release their listeners after SIGTERM, escalating to SIGKILL only for those still alive. Cover both delayed shutdown and forced termination before starting the replacement master.

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-10T12:36:55.407475Z	20e3e29	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20e3e2940d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[ji-huazhong]

cc @huniu20

[huniu20]

Overall LGTM. A few comments:

• Over-matching: pgrep -f mooncake_master matches full command lines, so processes like tail -f /tmp/mooncake_master.log get caught. They now get SIGKILL after the timeout, and the caller could even kill itself. Please filter by proc.name() == "mooncake_master" and exclude os.getpid(), or switch to psutil.process_iter(["name"]).

• AccessDenied: terminate() can raise psutil.AccessDenied, for example when the master belongs to another user. That exception escapes raw, and the PIDs already sent SIGTERM are never waited on. Please catch it and raise a RuntimeError that includes the PID.