dcp on m3 devices (internal display only) - #608
Open
sofus13 wants to merge 8 commits into
Open
Conversation
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
…ntested) Signed-off-by: sofus <sofus.c@icloud.com>
…ntested) Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
Signed-off-by: sofus <sofus.c@icloud.com>
chadmed
requested changes
Sep 9, 2026
| [113] = trampoline_true, /* create_nvram_service? */ | ||
| //[114] = trampoline_get_tiling_state, | ||
| //[115] = trampoline_false, /* set_tiling_state */ | ||
| [115] = trampoline_false, /* set_tiling_state */ |
Member
There was a problem hiding this comment.
This is actually get_tiling_state on 14.7, D116 is the set equivalent. See a-ramses's PR.
Author
There was a problem hiding this comment.
i will drop this in favor of a-ramses's PR
| <0x2 0x8f348000 0x0 0x4000>, /* dummy ? */ | ||
| <0x2 0x8f800000 0x0 0x800000>; | ||
| apple,bw-scratch = <&pmgr_dcp 0 5 0x988>; | ||
| apple,iomfb-surfaces = <1 1 0 1>; |
Member
There was a problem hiding this comment.
Have we tested various combinations of surface? I'm hoping that we have less buggy nonsense on the M3+ DCPs.
| }; | ||
|
|
||
| dcp: dcp@28ec00000 { | ||
| compatible = "apple,t6030-dcp", "apple,dcp"; |
Member
There was a problem hiding this comment.
The base DCPs run slightly different firmware to the Pro/Max DCPs, so this probably needs a t8122-dcp compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is some overlap with #607