Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3939
What changed
Textcomponent's icon was rendered insideDisplayText, which places it between the title (label) and the value. It is now passed to theLabel(new optionaliconprop onLabelProps) so it renders before the title, matching the behaviour specified in Text Component #2170.DisplayTextno longer takesiconUrl/iconAltText(it is only used byTextComponent).Note on verification
Dependency installation for this repo needs more disk space than was available in my environment, so I could not run the Jest suite locally. The change is small and behavior-preserving apart from the icon position:
iconis optional onLabelProps, so no otherLabelconsumer changes behavior.titleis set the early-return path is unchanged (and the icon was never rendered there before either).classes.iconstyling andtitle-based alt text; inverticaldirection it now sits above the title, as in the expected screenshot.Summary by CodeRabbit