Repository navigation
fix(validation): backport custom schema error messages to v4.36 (#4390) - #4400
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #4390 to
release/v4.36.Fields in definitions containing nested references now display their configured custom validation messages instead of the generic message. AJV's failing schema is used directly, preserving support for older data models and subschema validation.
The aggregate patch is unchanged from merged commit
289916014a6b0d8cdcff0d3fb48d93b6d4323310.Related Issue(s)
errorMessagefrom the data model when the definition has a nested$ref#4390errorMessagein the data model is ignored when the definition contains a$ref#4389 for the release branch.Verification/QA