Skip to content

[PWGLF] Fix xi0 mass calculation in sigma0builder - #18068

Merged
romainschotter merged 2 commits into
AliceO2Group:masterfrom
romainschotter:fix-xi0
Sep 27, 2026
Merged

[PWGLF] Fix xi0 mass calculation in sigma0builder#18068
romainschotter merged 2 commits into
AliceO2Group:masterfrom
romainschotter:fix-xi0

Conversation

@romainschotter

@romainschotter romainschotter commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Fix typo in xi0 mass calculation

@github-actions github-actions Bot added the pwglf label Sep 26, 2026
@github-actions github-actions Bot changed the title Fix xi0 mass calculation in sigma0builder [PWGLF] Fix xi0 mass calculation in sigma0builder Sep 26, 2026
@github-actions

github-actions Bot commented Sep 26, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 324 warnings, 🔕 0 disabled

@romainschotter
romainschotter marked this pull request as ready for review September 26, 2026 18:17
@romainschotter
romainschotter enabled auto-merge (squash) September 26, 2026 18:17
alibuild
alibuild previously approved these changes Sep 26, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Sep 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ec0e507 at 2026-09-26 22:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 182 warnings.'
Found 2 errors and 182 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/97bfa27f4e48931800007c3e7213b2588a26981c/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:46:1: error: included header TrackParametrization.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:2649:16: error: no header providing "o2::track::TrackParCov" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 182 -gt 0 ]]
++ cat /sw/BUILD/97bfa27f4e48931800007c3e7213b2588a26981c/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:79:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:412:9: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:413:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:414:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:415:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:416:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:417:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:418:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:419:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:515:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1103:226: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1107:274: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1254:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1256:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1258:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1262:91: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1264:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1266:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1350:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1356:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1361:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1539:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1544:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1549:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1554:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1559:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1564:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1569:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1574:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1579:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1584:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1589:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1594:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1599:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1604:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1609:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1614:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1620:21: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

@romainschotter Please remember to fix errors before merging.

@romainschotter
romainschotter enabled auto-merge (squash) September 26, 2026 20:48
alibuild
alibuild approved these changes Sep 26, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 516d796 at 2026-09-26 23:04:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 182 warnings.'
Found 1 errors and 182 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/64c31e234ef90f5536d60902fa84264a47cea776/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:2649:16: error: no header providing "o2::track::TrackParCov" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 182 -gt 0 ]]
++ cat /sw/BUILD/64c31e234ef90f5536d60902fa84264a47cea776/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:79:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:412:9: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:413:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:414:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:415:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:416:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:417:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:418:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:419:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:515:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1103:226: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1107:274: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1254:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1256:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1258:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1262:91: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1264:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1266:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1350:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1356:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1361:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1539:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1544:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1549:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1554:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1559:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1564:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1569:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1574:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1579:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1584:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1589:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1594:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1599:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1604:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1609:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1614:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1620:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Strangeness/sigma0builder.cxx:1625:21: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit c302af9 into AliceO2Group:master Sep 27, 2026
21 of 24 checks passed
@romainschotter
romainschotter deleted the fix-xi0 branch September 27, 2026 08:05
@vkucera

vkucera commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

Auto-approving on behalf of @romainschotter.

@romainschotter Thanks for the fix. It seems you are still missing ReconstructionDataFormats/Track.h which provides the definition of o2::track::TrackParCov. Please add it in your next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romainschotter @alibuild @vkucera