Skip to content

[PWGLF] Fix buildTrackedCascades in strangenessBuilderModule.h - #18062

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
romainschotter:fix-tracked-cascades
Sep 25, 2026
Merged

[PWGLF] Fix buildTrackedCascades in strangenessBuilderModule.h#18062
romainschotter merged 1 commit into
AliceO2Group:masterfrom
romainschotter:fix-tracked-cascades

Conversation

@romainschotter

@romainschotter romainschotter commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator
  • Fix buildTrackedCascades function such that it works without requiring that the standard cascade table is produced
  • Fill tracked cascades' covariance matrix table even if the standard cascades' covariance matrix table is not produced

Thank you very much @lubynets for reporting the bugs!

@github-actions github-actions Bot added the pwglf label Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 85 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix buildTrackedCascades function and filling of covariance matrix table [PWGLF] Fix buildTrackedCascades function and filling of covariance matrix table Sep 25, 2026
@romainschotter romainschotter changed the title [PWGLF] Fix buildTrackedCascades function and filling of covariance matrix table [PWGLF] Fix buildTrackedCascades in strangenessBuilderModule.h Sep 25, 2026
@romainschotter
romainschotter marked this pull request as ready for review September 25, 2026 16:31
@romainschotter
romainschotter enabled auto-merge (squash) September 25, 2026 16:32
alibuild
alibuild approved these changes Sep 25, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ec90a6d at 2026-09-25 20:40:

No log files found

Full log here.

@romainschotter
romainschotter merged commit b7924a6 into AliceO2Group:master Sep 25, 2026
15 of 17 checks passed
@romainschotter
romainschotter deleted the fix-tracked-cascades branch September 26, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romainschotter @alibuild