Skip to content

Resolve MegaLinter cppcheck failures in eventSelectionQa boolean logic #18060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+7 −9
Closed

Resolve MegaLinter cppcheck failures in eventSelectionQa boolean logic #18060

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
831d174
Initial plan
Copilot Sep 25, 2026
c0016be
Fix cppcheck boolean operation warnings in eventSelectionQa
Copilot Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions DPG/Tasks/AOTEvent/eventSelectionQa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ struct EventSelectionQaTask {
ccdb->setCaching(true);
ccdb->setLocalObjectValidityChecking();

const AxisSpec axisMultV0M{1000, 0., isLowFlux ? 40000. : 40000., "V0M multiplicity"};
const AxisSpec axisMultV0M{1000, 0., 40000., "V0M multiplicity"};
const AxisSpec axisMultV0A{1000, 0., isLowFlux ? 40000. : 200000., "V0A multiplicity"};
const AxisSpec axisMultV0C{1000, 0., isLowFlux ? 30000. : 30000., "V0C multiplicity"};
const AxisSpec axisMultV0C{1000, 0., 30000., "V0C multiplicity"};
const AxisSpec axisMultT0A{1000, 0., isLowFlux ? 10000. : 200000., "T0A multiplicity"};
const AxisSpec axisMultT0C{1000, 0., isLowFlux ? 2000. : 70000., "T0C multiplicity"};
const AxisSpec axisMultT0M{1000, 0., isLowFlux ? 12000. : 270000., "T0M multiplicity"};
Expand Down Expand Up @@ -568,9 +568,7 @@ struct EventSelectionQaTask {
histos.fill(HIST("hV0C012vsTklCol"), nTracklets, multRingV0C012);

// filling plots for accepted events
bool accepted = 0;
accepted |= !isINT1period & col.sel7();
accepted |= isINT1period & sel1;
bool accepted = (!isINT1period && col.sel7()) || (isINT1period && sel1);
if (!accepted) {
continue;
}
Expand Down Expand Up @@ -786,13 +784,13 @@ struct EventSelectionQaTask {
const auto& bcPast = bcs.iteratorAt(bc.globalIndex() - deltaIndex);
deltaBC = globalBC - bcPast.globalBC();
if (deltaBC < maxDeltaBC) {
pastActivityFT0 |= bcPast.has_ft0();
pastActivityFV0 |= bcPast.has_fv0a();
pastActivityFDD |= bcPast.has_fdd();
pastActivityFT0 = pastActivityFT0 || bcPast.has_ft0();
pastActivityFV0 = pastActivityFV0 || bcPast.has_fv0a();
pastActivityFDD = pastActivityFDD || bcPast.has_fdd();
}
}

bool pastActivity = pastActivityFT0 | pastActivityFV0 | pastActivityFDD;
bool pastActivity = pastActivityFT0 || pastActivityFV0 || pastActivityFDD;

int localBC = bc.globalBC() % nBCsPerOrbit;
float timeV0A = bc.has_fv0a() ? bc.fv0a().time() : -999.f;
Expand Down