Skip to content

[PWGCF] Adding task for multiplicity camculation in femto analysis - #18057

Merged
glromane merged 2 commits into
AliceO2Group:masterfrom
sofiatomassini:master
Sep 25, 2026
Merged

[PWGCF] Adding task for multiplicity camculation in femto analysis#18057
glromane merged 2 commits into
AliceO2Group:masterfrom
sofiatomassini:master

Conversation

@sofiatomassini

@sofiatomassini sofiatomassini commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Adding new Task in Femto3D for multiplicity calculation for femtoscopic analysis

@github-actions github-actions Bot changed the title Adding task for multiplicity camculation in femto analysis [PWGCF] Adding task for multiplicity camculation in femto analysis Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 142 warnings, 🔕 0 disabled

glromane
glromane previously approved these changes Sep 25, 2026
View reviewed changes
@glromane
glromane enabled auto-merge (squash) September 25, 2026 11:54
@alibuild

alibuild commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for d29fda2 at 2026-09-25 16:05:

No log files found

Full log here.

@alibuild

alibuild commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 475e8e5 at 2026-09-25 16:29:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 18 errors and 56 warnings.'
Found 18 errors and 56 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/59ca87d48933788f0064054019d97bde59f6f2da/O2Physics-code-check/errors.txt
PWGCF/Femto3D/Tasks/multEstimator.cxx:17:1: error: included header singletrackselector.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:29:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:30:1: error: included header Propagator.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:43:1: error: included header TH1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:46:1: error: included header array is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:90:16: error: no header providing "int16_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:120:8: error: no header providing "std::shared_ptr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:171:32: error: no header providing "std::make_shared" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:173:34: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:198:67: error: no header providing "o2::aod::evsel::kNoSameBunchPileup" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:200:68: error: no header providing "o2::aod::evsel::kIsGoodZvtxFT0vsPV" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:241:72: error: no header providing "o2::aod::pidits::ITSNSigmaPr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:274:67: error: no header providing "o2::aod::evsel::kIsVertexITSTPC" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:276:91: error: no header providing "o2::aod::evsel::kIsVertexTOFmatched" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:276:163: error: no header providing "o2::aod::evsel::kIsVertexTRDmatched" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:278:80: error: no header providing "o2::aod::evsel::kNoCollInTimeRangeStandard" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:280:73: error: no header providing "o2::aod::evsel::kIsGoodITSLayersAll" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:316:5: error: Value stored to 'cadidates_counter' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
++ [[ 56 -gt 0 ]]
++ cat /sw/BUILD/59ca87d48933788f0064054019d97bde59f6f2da/O2Physics-code-check/warnings.txt
PWGCF/Femto3D/DataModel/PIDutils.h:177:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:180:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:183:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:186:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:189:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:192:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:208:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGCF/Femto3D/DataModel/PIDutils.h:220:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:223:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:226:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:229:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:232:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:235:88: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d29fda2 at 2026-09-25 20:12:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 18 errors and 55 warnings.'
Found 18 errors and 55 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/3724d3941cf25d78d012aa6c3d1b35e23545bef7/O2Physics-code-check/errors.txt
PWGCF/Femto3D/Tasks/multEstimator.cxx:17:1: error: included header singletrackselector.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:29:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:30:1: error: included header Propagator.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:46:1: error: included header array is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:90:16: error: no header providing "int16_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:120:8: error: no header providing "std::shared_ptr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:173:32: error: no header providing "std::make_shared" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:175:27: error: no header providing "std::make_shared" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:178:34: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:203:67: error: no header providing "o2::aod::evsel::kNoSameBunchPileup" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:205:68: error: no header providing "o2::aod::evsel::kIsGoodZvtxFT0vsPV" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:247:72: error: no header providing "o2::aod::pidits::ITSNSigmaPr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:280:67: error: no header providing "o2::aod::evsel::kIsVertexITSTPC" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:282:91: error: no header providing "o2::aod::evsel::kIsVertexTOFmatched" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:282:163: error: no header providing "o2::aod::evsel::kIsVertexTRDmatched" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:284:80: error: no header providing "o2::aod::evsel::kNoCollInTimeRangeStandard" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:286:73: error: no header providing "o2::aod::evsel::kIsGoodITSLayersAll" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:324:5: error: Value stored to 'cadidates_counter' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/3724d3941cf25d78d012aa6c3d1b35e23545bef7/O2Physics-code-check/warnings.txt
PWGCF/Femto3D/DataModel/PIDutils.h:177:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:180:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:183:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:186:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:189:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:192:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:208:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGCF/Femto3D/DataModel/PIDutils.h:220:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:223:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:226:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:229:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:232:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/DataModel/PIDutils.h:235:88: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@glromane
glromane merged commit 2918b80 into AliceO2Group:master Sep 25, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glromane glromane glromane approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@dimihayl dimihayl Awaiting requested review from dimihayl dimihayl is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sofiatomassini @alibuild @glromane