Skip to content

[DPG] use metadata info to set isMC and NumberOfOrbitsPerTF - #18054

Merged
altsybee merged 2 commits into
AliceO2Group:masterfrom
altsybee:master
Sep 25, 2026
Merged

altsybee merged 2 commits into
AliceO2Group:masterfrom
altsybee:master

Conversation

@altsybee

Copy link
Copy Markdown
Collaborator

Use metadata info to set isMC flag (isMC configurable is therefore removed),
and also correctly set NumberOfOrbitsPerTF for MC, which can be e.g. 6 instead of 32.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 20 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title use metadata info to set isMC and NumberOfOrbitsPerTF [DPG] use metadata info to set isMC and NumberOfOrbitsPerTF Sep 25, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ba15679 at 2026-09-25 10:21:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ba15679 at 2026-09-25 10:53:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 71 warnings.'
Found 2 errors and 71 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/38ea88da352ca5ad113c98f380362020aa7276f3/O2Physics-code-check/errors.txt
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:124:61: error: 'true' and 'false' expressions are equivalent [misc-redundant-expression,-warnings-as-errors]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:126:61: error: 'true' and 'false' expressions are equivalent [misc-redundant-expression,-warnings-as-errors]
++ [[ 71 -gt 0 ]]
++ cat /sw/BUILD/38ea88da352ca5ad113c98f380362020aa7276f3/O2Physics-code-check/warnings.txt
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:63:34: warning: variable 'metadataInfo' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:71:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:90:15: warning: redundant string initialization [readability-redundant-string-init]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:91:15: warning: redundant string initialization [readability-redundant-string-init]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:105:27: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:124:52: warning: conditional operator with identical true and false expressions [bugprone-branch-clone]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:126:52: warning: conditional operator with identical true and false expressions [bugprone-branch-clone]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:426:25: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:432:7: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:435:65: warning: implicit conversion 'bool' -> 'Double_t' (aka 'double') [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:496:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:497:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:545:36: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:548:36: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:581:23: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:582:19: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:582:35: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:583:19: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:583:34: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:682:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:684:15: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:739:47: warning: statement should be inside braces [readability-braces-around-statements]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:793:30: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:794:30: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:795:30: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:810:27: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:810:27: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:810:45: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
DPG/Tasks/AOTEvent/eventSelectionQa.cxx:810:63: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
[0 more errors; see full log]

Full log here.

@altsybee
altsybee merged commit f2cb248 into AliceO2Group:master Sep 25, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants