Skip to content

[PWGCF] Add efficiency corrections and rename and redesign some features - #18049

Merged
abilandz merged 4 commits into
AliceO2Group:masterfrom
meiALICE:master
Sep 25, 2026
Merged

abilandz merged 4 commits into
AliceO2Group:masterfrom
meiALICE:master

Conversation

@meiALICE

Copy link
Copy Markdown
Contributor

Add full efficiency corrections.

Rename some variables.

Change some features and design.

Clean up codes.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add efficiency corrections and rename and redesign some features [PWGCF] Add efficiency corrections and rename and redesign some features Sep 24, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 0f4a373 at 2026-09-24 19:38:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0f4a373 at 2026-09-24 19:46:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/e6538f1ad9f5cffc68578c4abeff51eaccc685c0/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:41:1: error: included header TParticlePDG.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for c02e16d at 2026-09-24 20:07:

No log files found

Full log here.

abilandz
abilandz previously approved these changes Sep 24, 2026
@abilandz

Copy link
Copy Markdown
Collaborator

This compilation failure on macOS-arm has nothing to do with your code, let's ask @vkucera again how to proceed...

@abilandz
abilandz requested a review from vkucera September 25, 2026 05:18
@vkucera

vkucera commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

This compilation failure on macOS-arm has nothing to do with your code, let's ask @vkucera again how to proceed...

The machine ran out of disk space. It should be fixed now.

@meiALICE

Copy link
Copy Markdown
Contributor Author

This compilation failure on macOS-arm has nothing to do with your code, let's ask @vkucera again how to proceed...

The machine ran out of disk space. It should be fixed now.

Thank you for your reply! I will have another commit and push with some other changes shortly.

@abilandz
abilandz enabled auto-merge (squash) September 25, 2026 13:44
@abilandz
abilandz merged commit 8f09b7b into AliceO2Group:master Sep 25, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants