Skip to content

[PWGJE] TOF-veto selection fixed - #17971

Merged
nzardosh merged 5 commits into
AliceO2Group:masterfrom
arvindkhuntia:master
Sep 21, 2026
Merged

nzardosh merged 5 commits into
AliceO2Group:masterfrom
arvindkhuntia:master

Conversation

@arvindkhuntia

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 57 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 20b21e7 at 2026-09-19 13:16:

## sw/BUILD/re2-latest/log
CMake Error at CMakeLists.txt:84 (find_package):

Full log here.

@alibuild

alibuild commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ddccf35 at 2026-09-20 11:53:

## sw/BUILD/VecGeom-latest/log
CMake Error at /container/bits/sw/BUILD/4b902089e8ae3e1235b16cffffe5b41003a490dd/VecGeom/buildExternals/VecCore-0.8.0/build/external/stamp/VecCore-0.8.0-configure-RELWITHDEBINFO.cmake:49 (message):
ninja: build stopped: subcommand failed.
CMake Error at cmake/modules/BuiltinVecCore.cmake:36 (add_custom_command):
CMake Error at CMakeLists.txt:222 (find_package):

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ddccf35 at 2026-09-20 09:41:

No log files found

Full log here.

@alibuild

alibuild commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for ddccf35 at 2026-09-20 11:57:

## sw/BUILD/VecGeom-latest/log
CMake Error at /container/bits/sw/BUILD/4b902089e8ae3e1235b16cffffe5b41003a490dd/VecGeom/buildExternals/VecCore-0.8.0/build/external/stamp/VecCore-0.8.0-configure-RELWITHDEBINFO.cmake:49 (message):
ninja: build stopped: subcommand failed.
CMake Error at cmake/modules/BuiltinVecCore.cmake:36 (add_custom_command):
CMake Error at CMakeLists.txt:222 (find_package):

Full log here.

float jetPt = -999.;

if (isWithLeadingJet) {
if (!isConeAxisAccepted(leadingJetPtEtaPhi[1])) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check this logic please?
It seems that if you dont find a jet and isWithJetEvents is false, then isWithLeadingJet is still true and you go into the fillTrackInfo and pass it leadingJetPtEtaPhi[1] which has a default value of zero. This gives you a fake jet where there shouldnt be one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nzardosh,

Thank you for pointing this out. Without a valid leading-jet guard, the default {0,0,0} vector could create a fake jet/perpendicular cone when isWithJetEvents=false and no jet is found. I fixed it by adding an explicit valid-leading-jet check. Many thanks.

@nzardosh
nzardosh enabled auto-merge (squash) September 21, 2026 09:11
@nzardosh

Copy link
Copy Markdown
Collaborator

Btw isConeAxisAccepted is not applied in processMCRec but it is in the others

@arvindkhuntia

Copy link
Copy Markdown
Contributor Author

Currently, I am not using processMCRec process function but for consistency I can add isConeAxisAccepted in the next PR. Many thanks.

@nzardosh
nzardosh merged commit 91be96c into AliceO2Group:master Sep 21, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants