[PWGLF] Apply a different event selection for PbPb in the feeddown part of hStrangenessCorrelation.cxx - #17951
Open
gengjiabin12 wants to merge 3 commits into
Open
gengjiabin12 wants to merge 3 commits into
gengjiabin12 wants to merge 3 commits into
Conversation
gengjiabin12
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
September 17, 2026 14:54
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
lhusova
requested changes
Sep 17, 2026
| histos.add("hEventSelection", "hEventSelection", kTH1F, {{10, 0, 10}}); | ||
| std::array<TString, 10> eventSelLabel = {"all", "sel8", "kIsTriggerTVX", "PV_{z}", "kIsGoodITSLayersAll", "kIsGoodZvtxFT0vsPV", "OccupCut", "kNoTimeFrameBorder", "kNoITSROFrameBorder", "kNoSameBunchPileup "}; | ||
| histos.add("hEventSelection", "hEventSelection", kTH1F, {{11, 0, 11}}); | ||
| std::array<TString, 11> eventSelLabel = {"all", "sel8", "kIsTriggerTVX", "PV_{z}", "Cent", "kIsGoodITSLayersAll", "kIsGoodZvtxFT0vsPV", "OccupCut", "kNoTimeFrameBorder", "kNoITSROFrameBorder", "kNoSameBunchPileup "}; |
Collaborator
There was a problem hiding this comment.
you fill the PV and centrality in opposite order as the axis labels are written, it would be better to make it consistent
| return false; | ||
| } | ||
| if (fillHists) { | ||
| histos.fill(HIST("hEventSelection"), 3.5 /* collisions after sel pvz sel*/); |
Collaborator
There was a problem hiding this comment.
this comment is not valid anymore, as this will be after centrality selection
lhusova
enabled auto-merge (squash)
September 17, 2026 15:09
lhusova
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.