Skip to content

[PWGCF] diHadron, flowDecorr DCAxy cut update - #17936

Open
lcernusa wants to merge 1 commit into
AliceO2Group:masterfrom
lcernusa:master
Open

lcernusa wants to merge 1 commit into
AliceO2Group:masterfrom
lcernusa:master

Conversation

@lcernusa

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c981483 at 2026-09-16 20:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 25 errors and 259 warnings.'
Found 25 errors and 259 warnings.
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/fbe241473de00678e1188f13eb600ade97653e30/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:353:43: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:400:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:409:32: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:485:29: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:485:48: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:527:33: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:527:55: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:590:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:617:50: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:617:72: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:693:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:713:35: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:713:57: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:761:33: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:498:58: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:622:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:727:29: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:727:48: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:774:39: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:912:39: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:966:33: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1457:39: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1457:61: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1720:35: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1720:57: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 259 -gt 0 ]]
++ cat /sw/BUILD/fbe241473de00678e1188f13eb600ade97653e30/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:62:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:64:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:250:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:252:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:255:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:257:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:260:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:262:56: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:265:54: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:267:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:379:11: warning: variable 'cent' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:402:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:431:40: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:432:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:434:23: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants