Skip to content

[PWGCF] Flow decorr PR test - #17930

Closed
lcernusa wants to merge 0 commit into
AliceO2Group:masterfrom
lcernusa:master
Closed

lcernusa wants to merge 0 commit into
AliceO2Group:masterfrom
lcernusa:master

Conversation

@lcernusa

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7af3fff at 2026-09-16 11:04:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 162 warnings.'
Found 10 errors and 162 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/0abaa751cbc45c6badcd4522b67f81cb455af60d/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:616:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:718:29: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:718:48: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:765:39: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:902:39: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:955:33: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1455:39: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1455:61: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1717:35: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:1717:57: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 162 -gt 0 ]]
++ cat /sw/BUILD/0abaa751cbc45c6badcd4522b67f81cb455af60d/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:63:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:64:8: warning: constructor does not initialize these fields: ccdb, offsetFT0, offsetFV0, tofNsigmaCut, itsNsigmaCut, tpcNsigmaCut [cppcoreguidelines-pro-type-member-init]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:205:35: warning: initializer for member 'cstFT0RelGain' is redundant [readability-redundant-member-init]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:343:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:345:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:348:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:350:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:353:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:355:56: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:358:54: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:360:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:504:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:507:85: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:510:110: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:519:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:525:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:534:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:540:11: warning: variable 'offsetX' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:540:20: warning: variable 'offsetY' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:540:29: warning: variable 'offsetZ' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:595:11: warning: variable 'cent' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:664:40: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:665:11: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:667:23: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:676:46: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:697:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:706:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:708:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:710:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/flowDecorrelation.cxx:723:34: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants