Skip to content

[PWGJE] adding zdc info for upc and adding proper hf matching - #17913

Merged
nzardosh merged 1 commit into
AliceO2Group:masterfrom
nzardosh:fix
Sep 16, 2026
Merged

nzardosh merged 1 commit into
AliceO2Group:masterfrom
nzardosh:fix

Conversation

@nzardosh

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 100 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title adding zdc info for upc and adding proper hf matching [PWGJE] adding zdc info for upc and adding proper hf matching Sep 15, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for eed7035 at 2026-09-15 09:51:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for eed7035 at 2026-09-15 09:52:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for eed7035 at 2026-09-15 09:53:

No log files found

Full log here.

Comment thread PWGJE/Core/JetDQUtilities.h
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for e25da72 at 2026-09-15 13:22:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGJE/TableProducer/derivedDataProducer.cxx:301:269: error: unused parameter 'bcs' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for e25da72 at 2026-09-15 13:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducer.cxx:301:269: error: unused parameter 'bcs' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e25da72 at 2026-09-15 15:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 75 warnings.'
Found 2 errors and 75 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/296669ef3422a4e76a90899c3ba18f310ce68e32/O2Physics-code-check/errors.txt
PWGJE/TableProducer/derivedDataProducer.cxx:301:269: error: parameter 'bcs' is unused [misc-unused-parameters,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducer.cxx:301:269: error: unused parameter 'bcs' [clang-diagnostic-unused-parameter,-warnings-as-errors]
++ [[ 75 -gt 0 ]]
++ cat /sw/BUILD/296669ef3422a4e76a90899c3ba18f310ce68e32/O2Physics-code-check/warnings.txt
PWGJE/Core/JetCandidateUtilities.h:37:53: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetCandidateUtilities.h:55:55: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetCandidateUtilities.h:72:49: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetCandidateUtilities.h:89:51: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetCandidateUtilities.h:190:53: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetDQUtilities.h:150:45: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetDQUtilities.h:171:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetDQUtilities.h:172:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:333:37: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetHFUtilities.h:361:39: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetHFUtilities.h:388:106: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetHFUtilities.h:415:110: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetHFUtilities.h:569:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:570:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:575:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:576:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:581:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:582:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:587:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:588:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:593:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:594:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:599:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:600:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:605:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:606:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:611:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:612:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:617:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:618:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:623:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:624:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:629:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:630:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:635:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:636:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetHFUtilities.h:641:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetHFUtilities.h:642:7: warning: do not use 'else' after 'return' [readability-else-after-return]
[0 more errors; see full log]

Full log here.

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @nzardosh.

@nzardosh
nzardosh disabled auto-merge September 16, 2026 08:58
@nzardosh
nzardosh enabled auto-merge (squash) September 16, 2026 08:58

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @nzardosh.

@nzardosh
nzardosh merged commit 71308ce into AliceO2Group:master Sep 16, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants