Skip to content

[Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [WIP] [ML] Fix for memory issue in ML headers - #17836

Open
ChSonnabend wants to merge 3 commits into
AliceO2Group:masterfrom
ChSonnabend:mlfix
Open

ChSonnabend wants to merge 3 commits into
AliceO2Group:masterfrom
ChSonnabend:mlfix

Conversation

@ChSonnabend

Copy link
Copy Markdown
Contributor

This PR fixes the dangling float* pointers and replaces it with a std::vector allocation.

@ChSonnabend ChSonnabend changed the title [ML] Fix for memory issue in ML headers [WIP] [ML] Fix for memory issue in ML headers Sep 8, 2026
@github-actions github-actions Bot changed the title [WIP] [ML] Fix for memory issue in ML headers [Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [ML] Fix for memory issue in ML headers Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 357 errors, ⚠️ 131 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [ML] Fix for memory issue in ML headers [Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [WIP] [ML] Fix for memory issue in ML headers Sep 8, 2026
@ChSonnabend

ChSonnabend commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

This still needs to be tested but should fix a memory issue spotted by @mhemmer-cern and discussed with @fmazzasc
Please do not merge yet.

@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for be8a4a7 at 2026-09-08 20:34:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Tools/ML/MlResponse.h:232:85: error: cannot convert 'std::vector<float>' to 'float*' in initialization
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for be8a4a7 at 2026-09-08 20:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Tools/ML/MlResponse.h:232:85: error: cannot convert 'std::vector<float>' to 'float*' in initialization
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for be8a4a7 at 2026-09-08 21:04:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Tools/ML/MlResponse.h:232:85: error: cannot convert 'std::vector<float>' to 'float*' in initialization
ninja: build stopped: subcommand failed.

Full log here.

romainschotter
romainschotter previously approved these changes Sep 8, 2026
@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a31fa89 at 2026-09-18 07:23:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/Common/Tools/PID/pidTPCModule.h:612:82: error: 'class std::unique_ptr<float []>' has no member named 'begin'
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants