Fixing a 2-tag problem when modulefiles contain @ - #2463
Merged
Merged
Conversation
This fixes a problem in the 2-tag setup of anchorMC.sh and anchorMC_DataEmbedding.sh. - The MC software environment was stashed with 'module save' and brought back with 'module restore'. - 'module restore' fails for a module whose version contains '@', as gpu-system did since alidist of 2026-09-05. - ONNXRuntime depends on gpu-system, so O2, O2Physics, QualityControl and O2PDPSuite were not restored. - o2dpg_sim_workflow_anchored.py then failed with "o2 has no attribute ccdb" and no AO2D was produced. - The alternative-reco step now runs in a subshell, so the MC environment is never modified and nothing needs restoring. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
changed the title
@
This addresses review comments on the 2-tag subshell change. - The modulecmd probe now checks 'bash list' instead of 'savelist', since save/restore is no longer used. - anchorMC_DataEmbedding.sh now uses the same modulecmd resolution as anchorMC.sh. - A failing 'alienv printenv' of the async tag now stops with a clear error. - The embedding script passes env_async.env with the path of the top directory, not the per-timeframe one. - '2&>' is replaced by '&>' when calling async_pass.sh. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 2-tag mode, anchorMC stashed the MC environment with
module saveand brought it back withmodule restore.module restorecannot locate modules whose version contains@(e.g.gpu-system), so O2 and its dependents were missing afterwards and the anchoring failed.The alternative-reco step now runs in a subshell, so the MC environment is never modified and no restore is needed.
Applied to
anchorMC.shandanchorMC_DataEmbedding.sh; tested on the GRID with the 2-tag payload ondaily-20260915.