[ALICE 3] FT3 fix magnetic field silently disabled when FT3 is active - #15828
Merged
njacazio merged 5 commits intoSep 23, 2026
Merged
Conversation
FT3Module::initialize_materials() registered its six support materials via raw `new TGeoMedium(name, id, mat), bypassing o2::base::MaterialManager. That 3-argument TGeoMedium constructor leaves all tracking parameters, including ifield, at 0, and since these ids were never coordinated with MaterialManager's auto-assigned global ids, they collided with other detectors' media -notably the CAVE air medium that fills the gaps between TRK's barrel layers. Route these six materials/media through MaterialManager instead.
bulukutlu
requested review from
fcolamar,
mconcas and
njacazio
as code owners
September 22, 2026 15:02
Removed commented-out code regarding material registration and its implications.
Please consider the following formatting changes to AliceO2Group#15828
Collaborator
Collaborator
Collaborator
|
Ciao @bulukutlu thanks! I wonder, could it all be done in the |
Contributor
Author
|
Hi @njacazio, indeed, @JustusRudolph you wanted to do such a modification, should I modify this PR to move the materials to Detector as suggested, or would you prefer to do this later? |
Collaborator
|
If it's not overkill I would do it now |
njacazio
enabled auto-merge (squash)
September 23, 2026 12:05
njacazio
approved these changes
Sep 23, 2026
njacazio
left a comment
njacazio
left a comment
Collaborator
There was a problem hiding this comment.
Hi, I merge since the CI is green. But let's unify the material definition in a coming PR please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FT3Module::initialize_materials() registered its six support materials via raw `new TGeoMedium(name, id, mat), bypassing o2::base::MaterialManager. That 3-argument TGeoMedium constructor leaves all tracking parameters, including ifield, at 0, and since these ids were never coordinated with MaterialManager's auto-assigned global ids, they collided with other detectors' media -notably the CAVE air medium that fills the gaps between TRK's barrel layers.
Route these six materials/media through MaterialManager instead.