[TF3] Improve digit efficiency in stepping - #15804
Open
Marcellocosti wants to merge 3 commits into
Open
Marcellocosti wants to merge 3 commits into
Marcellocosti wants to merge 3 commits into
Conversation
Marcellocosti
requested review from
fcolamar,
mconcas and
njacazio
as code owners
September 16, 2026 12:27
Contributor
Author
Behaviour before this PR when activating stepping and pixel passive edges ( `ChipSpecificsParam.PixelPassiveEdgeX`, `ChipSpecificsParam.PixelPassiveEdgeZ`)
|
Contributor
Author
Behaviour with the same configuration and changes introduced in this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code was stopping the propagation of hits with average position within pixel passive edges, affecting the hit propagation when stepping is switched on.
This behaviour is extended by moving the
isEfficient()check and passive-area checks from the hit to the step level. Moreover, the charge threshold check now takes into account the fraction of charge deposited across multiple pixels, instead of the total charge deposited by the hit.The default number of steps in hit stepping is also changed to 10 steps.
Tagging @maciacco @GiorgioAlbertoLucia, please let me now if the implementation looks ok to you!