Repository navigation
fix(relay-node): repair native Codex registration and hook delivery #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrei-rizoiu
wants to merge
11
commits into
AgentWorkforce:main
Choose a base branch
from
andrei-rizoiu:fix/codex-runtime-registration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7c704f2
fix(relay-node): register loaded Codex chats without a window owner
andrei-rizoiu 07bea47
Merge remote-tracking branch 'origin/main' into fix/codex-runtime-reg…
andrei-rizoiu 87590b2
fix(relay-node): recognise native remote user turns and address revie…
andrei-rizoiu b2d693f
Merge upstream main into Codex registration repair
andrei-rizoiu 8e21627
fix(relay-node): separate identity guidance and cache runtime presence
andrei-rizoiu 10ca12f
fix(relay-node): bind Unix runtime proofs to exact files
andrei-rizoiu 03cdf2b
fix(relay-node): bind runtime admission to the configured Codex home
andrei-rizoiu bf0aa8d
fix(relay-node): remember identity context supplied at session start
andrei-rizoiu 4fe750b
fix(relay-node): acknowledge startup identity after helper output
andrei-rizoiu ea1ff6b
Merge remote-tracking branch 'upstream/main' into fix/codex-runtime-r…
andrei-rizoiu 793f712
fix(relay-node): keep session hooks working through private runtime l…
andrei-rizoiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A panic in
activate_new_sessionsleavescodex_discovery_refreshset forever.Line 257 sets
codex_discovery_refreshbefore the task is spawned. Line 268 clears the flag only after all three passes finish. Ifactivate_new_sessionspanics, the spawned task stops and Line 268 never runs. Every laterrequest_codex_discoverycall then returns at Line 258. Hook-triggered discovery stops until the daemon restarts.Clear the flag with a drop guard so it is reset on every exit path.
🛡️ Proposed fix
let core = self.clone(); tokio::spawn(async move { + struct Reset(Arc<Core>); + impl Drop for Reset { + fn drop(&mut self) { + self.0.codex_discovery_refresh.store(false, Ordering::Release); + } + } + let _reset = Reset(core.clone()); for attempt in 0..3 { if attempt > 0 { tokio::time::sleep(std::time::Duration::from_millis(500)).await; } core.activate_new_sessions().await; } - core.codex_discovery_refresh.store(false, Ordering::Release); });Committable suggestion