Repository navigation
feat(settings): move Desktop downloads under Settings > Workspace - #133
Conversation
- Remove the top-level Downloads item from the workspace nav. - Show the Desktop downloads (per-OS installers, version, checksums, CLI install) as a card on Settings > Workspace, directly below "Connect your agents". The Workspace tab is visible to members, as Downloads was. - #/downloads and the /downloads path keep working: they render Settings > Workspace and the URL is rewritten to #/settings/workspace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review.
|
The rewrite ran in an effect keyed on hash state, which stayed #/downloads, so following the same old link again kept the old URL. The rewrite now happens wherever the hash is read (initial state and hashchange/popstate), and the test follows the old link twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
Product ask: no dedicated Downloads tab; put downloads under the Workspace settings.
#/downloadsand the/downloadspath still work. They render Settings > Workspace and rewrite the URL to#/settings/workspacewithreplaceState, so the back button isn't polluted. Deep links and docs that use them keep working.Tests
downloads.test.tsx: all existing downloads behaviour now runs on the embeddedDesktopDownloadscomponent. A test checks the nav has no Downloads link, and another that the card is a titled region.admin.test.tsx: the retired#/downloadslink lands on Settings > Workspace with the downloads card, the URL becomes#/settings/workspace, and there is no Downloads nav link.npm run checkis green locally (58 files, 907 tests).🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.