Skip to content

feat(settings): move Desktop downloads under Settings > Workspace - #133

Merged
khaliqgant merged 2 commits into
mainfrom
feat/downloads-in-workspace
Nov 11, 2026
Merged

khaliqgant merged 2 commits into
mainfrom
feat/downloads-in-workspace

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

What

Product ask: no dedicated Downloads tab; put downloads under the Workspace settings.

  • Nav: the top-level Downloads item is gone from the workspace nav. Sessions and the rest are unchanged.
  • Settings > Workspace: the Desktop downloads now render as a card ("Download ") directly below Connect your agents. It keeps everything the Downloads page had: the release/channel picker, the recommended download for the detected OS, all per-OS installers with version and checksums, and the command-line install. The Workspace tab is not admin-only, so members still see downloads, as before.
  • Old links: #/downloads and the /downloads path still work. They render Settings > Workspace and rewrite the URL to #/settings/workspace with replaceState, so the back button isn't polluted. Deep links and docs that use them keep working.

Tests

  • downloads.test.tsx: all existing downloads behaviour now runs on the embedded DesktopDownloads component. A test checks the nav has no Downloads link, and another that the card is a titled region.
  • admin.test.tsx: the retired #/downloads link lands on Settings > Workspace with the downloads card, the URL becomes #/settings/workspace, and there is no Downloads nav link.

npm run check is green locally (58 files, 907 tests).

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff

- Remove the top-level Downloads item from the workspace nav.
- Show the Desktop downloads (per-OS installers, version, checksums, CLI
  install) as a card on Settings > Workspace, directly below "Connect your
  agents". The Workspace tab is visible to members, as Downloads was.
- #/downloads and the /downloads path keep working: they render Settings >
  Workspace and the URL is rewritten to #/settings/workspace.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T21:45:47.026992Z ecdb8c0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 57067e95-1b98-4c71-aa40-3fdd53dec2d7
Commits

Reviewing files that changed from the base of the PR and between ecdb8c0 and ad7d127.

Files selected for processing: 2

  • src/admin/admin.test.tsx
  • src/app.tsx

No actionable comments were generated in the recent review.

Walkthrough

The Downloads view now appears in Workspace Settings. Requests to retired Downloads URLs redirect to that section, and the Downloads navigation entry is removed.

Changes: Downloads in Workspace Settings

Layer / File(s) Summary
Embed the Downloads view in Settings
src/admin/downloads.tsx, src/admin/downloads.module.css, src/admin/settings.tsx, src/admin/downloads.test.tsx
DownloadsPage is renamed to DesktopDownloads and rendered as an embedded section after DesktopSection. The view gains a “Download [product]” heading and embedded styling. Tests continue to cover download behavior and verify the embedded region.
Redirect retired Downloads URLs
src/app.tsx, src/shell/shell.tsx, src/shell/workspace-chrome.tsx, src/admin/admin.test.tsx, src/admin/downloads.test.tsx
The app redirects #/downloads and a /downloads pathname without a hash to #/settings/workspace, preserving the history state. The Downloads rail option is removed. Tests verify the redirect and updated navigation.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant App
  participant Settings
  participant DesktopDownloads
  Browser->>App: Open retired Downloads URL
  App->>App: Replace URL with Settings Workspace URL
  App->>Settings: Render Settings route
  Settings->>DesktopDownloads: Render embedded Downloads section
Loading

Possibly related PRs

Suggested reviewers: kjgbot

Merge Risk: Minimal · previous review ecdb8

Desktop downloads move into Settings > Workspace, and the old downloads links redirect there. No actionable merge-blocking risk was found in the supplied changes.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Desktop downloads move under Settings > Workspace. It uses the conventional feat(scope) prefix and matches the changeset, which removes the Downloads nav item, adds th…
Description check Passed The description states the product ask, the nav removal, the new Settings > Workspace card, the preserved features, the old-link redirect with replaceState, and the test changes. These match the chang…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: Desktop downloads move under Settings > Workspace. It uses the conventional feat(scope) prefix and matches the changeset, which removes the Downloads nav item, adds the DesktopDownloads card to Settings, and adds redirects from the old route.

Full details: Description check

Explanation

The description states the product ask, the nav removal, the new Settings > Workspace card, the preserved features, the old-link redirect with replaceState, and the test changes. These match the changed files in src/admin, src/app.tsx, src/shell, and settings.tsx.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit hops to Settings’ door,
Where Downloads rests, embedded once more.
Old paths now turn to Workspace light,
No Downloads link remains in sight.
The installers wait, all snug and neat,
While thumping paws review the feat.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 58e752fe-fcf6-499f-80d6-38c9fb0ada71
Commits

Reviewing files that changed from the base of the PR and between 300aeed and ecdb8c0.

Files selected for processing: 8

  • src/admin/admin.test.tsx
  • src/admin/downloads.module.css
  • src/admin/downloads.test.tsx
  • src/admin/downloads.tsx
  • src/admin/settings.tsx
  • src/app.tsx
  • src/shell/shell.tsx
  • src/shell/workspace-chrome.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain from this review.

Summary

Desktop downloads move into Settings > Workspace, and the separate Downloads navigation item is removed.

  • Desktop downloads now appear in Workspace settings.

Reviews (2) · Last reviewed commit: "fix(app): rewrite a retired Downloads li..." · Reviewed by Greptile

Comment thread src/app.tsx Resolved
The rewrite ran in an effect keyed on hash state, which stayed #/downloads,
so following the same old link again kept the old URL. The rewrite now
happens wherever the hash is read (initial state and hashchange/popstate),
and the test follows the old link twice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@khaliqgant
khaliqgant merged commit 7259485 into main Nov 11, 2026
6 checks passed
@khaliqgant
khaliqgant deleted the feat/downloads-in-workspace branch November 11, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant