Skip to content

Wait for the final PostgreSQL fixture server - #248

Merged
miyaontherelay merged 1 commit into
mainfrom
fix/erase-fixture-final-server
Nov 11, 2026
Merged

miyaontherelay merged 1 commit into
mainfrom
fix/erase-fixture-final-server

Conversation

@miyaontherelay

@miyaontherelay miyaontherelay commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

The RDS eraser-role fixture can pass pg_isready against the PostgreSQL image's temporary Unix-socket initialization server, then run its first SQL command while that server is shutting down. This failed the static job on infra#247 with a missing socket before the new acceptance tests ran.

Probe127.0.0.1 over TCP instead: the initialization server has TCP disabled, so readiness waits for the final server. Keep the existing bounded wait and every role/SQL assertion unchanged.

Validation: bash syntax and git diff --check pass. A stateful fake-Docker startup-race fixture reproduces the old prefix exiting2 after temporary-server readiness and the fixed prefix exiting0 after final TCP readiness; no real Docker/target operations. The existing CI test provides the real PostgreSQL integration run.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 265c481e-163f-4d34-8209-2e94e3229c42
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kjgbot kjgbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source review of exact head 64fc8b2: no actionable findings. The official PostgreSQL entrypoint starts its temporary initialization server with listen_addresses empty, so explicitly probing 127.0.0.1 waits for final TCP startup. Independently reproduced the readiness/first-SQL boundary with a stateful fake Docker: old prefix exits 2; fixed prefix exits 0; permanent unready fixture still exits 1 at the existing bounded limit. Confirmed the entire script after the readiness wait (all role/SQL assertions) is byte-identical to base. bash -n and git diff --check pass. No real Docker, database or ar-lap operations performed; real PostgreSQL integration remains the CI fixture check.

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This focused readiness fix appears safe to merge.

Summary

The fixture now probes 127.0.0.1 over TCP to wait for the final PostgreSQL server.

  • The eraser fixture waits for PostgreSQL’s final server before running SQL checks.

Reviews (1) · Last reviewed commit: "fix(ci): wait for the final PostgreSQL f..." · Reviewed by Greptile

@miyaontherelay
miyaontherelay merged commit 712e26b into main Nov 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants