feat: plugin quicktool adapter - #2898
Open
deadlyjack wants to merge 4 commits into
Open
Conversation
- allow plugin to adapt quicktool - allow plugin to hook save, save event - fix icon size in file explorer
Contributor
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
- improve tooltip bug and visibility - UI issues
This comment was marked as outdated.
This comment was marked as outdated.
Comment on lines
+1901
to
1909
| if ( | ||
| !fsOperation.hasProvider(this.uri) && | ||
| !isInitialPluginLoadComplete() | ||
| ) { | ||
| await waitForInitialPluginLoad(); | ||
| } | ||
| if (!this.#tab) return; | ||
| file ||= fsOperation(this.uri); | ||
| const fileExists = await file.exists(); |
Member
There was a problem hiding this comment.
Slow provider startup can delete recovery data
waitForInitialPluginLoad() resolves when the 15-second plugin-load race finishes, even though a timed-out plugin continues loading in the background. If its filesystem provider registers after that timeout, fsOperation(this.uri) is still undefined here and .exists() throws. The catch path removes the restored tab, and destruction can delete its cached unsaved content. Keep the tab pending until the provider registers, or fail without removing the tab/cache.
bajrangCoder
requested changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.