Repository navigation
fix(v21): mark disabled datepicker cells as aria-disabled - #906
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
October 29, 2026 17:49
Contributor
Coverage report for library
Test suite run success3285 tests passing in 76 suites. Report generated by 🧪jest coverage report action from 9af4122 |
Collaborator
Author
|
Note for reviewers: this PR is based on the #903 branch, so its diff and commit list currently include the #903 backport commits. The only change belonging to this PR is the last commit, Merge #903 first, then rebase this PR onto |
Contributor
Playwright test results
Details
|
fateeand
force-pushed
the
fix/905-datepicker-aria-disabled-v21
branch
from
October 29, 2026 18:46
2d41f27 to
5ca5c8d
Compare
lukasmatta
reviewed
Oct 30, 2026
lukasmatta
left a comment
lukasmatta
left a comment
Collaborator
There was a problem hiding this comment.
nice work, left one minor comment
… before re-observing
lukasmatta
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #905
v21 counterpart of #892. On
masterthe fix patches the vendored PrimeNG datepicker; v21 uses theprimengpackage, soCpsDatepickerComponentinstead patches the rendered calendar DOM (via aMutationObserveron the calendar overlay while it is open):role="button", andaria-disabled="true"when they carryp-disabled<td>getsaria-disabled="true"too (empty other-month cells have no day<span>, so they are left alone)aria-labelwith their visible text, so the hidden live region in the selected cell doesn't double the accessible nameTests: new unit tests render the real calendar; the Playwright min-date assertions from #892 are ported.
Depends on #903 - this branch is based on it, so the diff shows its commits until #903 is merged. Merge #903 first.
Verified: typecheck, lint, datepicker unit tests, Playwright datepicker spec, and the datepicker axe scans (component and composition page, desktop and mobile).