Repository navigation
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
October 27, 2026 08:38
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified, and the loading behavior is covered by unit and end-to-end tests.
No open issues 🎉
What changed in this PR
Adds a dataReloadBtnLoading input to table and tree-table components, keeping reload buttons focusable during asynchronous data reloads while preventing duplicate actions.
Changes:
- Added and documented the loading input for both table components.
- Propagated loading state to reload buttons and guarded reload events while loading.
- Updated composition examples, API metadata, unit tests, and Playwright coverage.
| File | Description |
|---|---|
projects/cps-ui-kit/src/lib/components/cps-tree-table/cps-tree-table.component.ts |
Adds the loading input and reload guard for tree tables. |
projects/cps-ui-kit/src/lib/components/cps-tree-table/cps-tree-table.component.spec.ts |
Tests tree-table loading, focus, and reload behavior. |
projects/cps-ui-kit/src/lib/components/cps-tree-table/cps-tree-table.component.html |
Passes loading state to the tree-table reload button. |
projects/cps-ui-kit/src/lib/components/cps-table/cps-table.component.ts |
Adds the loading input and reload guard for tables. |
projects/cps-ui-kit/src/lib/components/cps-table/cps-table.component.spec.ts |
Tests table loading, focus, and reload behavior. |
projects/cps-ui-kit/src/lib/components/cps-table/cps-table.component.html |
Passes loading state to the table reload button. |
projects/composition/src/app/pages/tree-table-page/tree-table-page.examples.ts |
Updates the tree-table code example with loading-state usage. |
projects/composition/src/app/pages/tree-table-page/tree-table-page.component.ts |
Simulates asynchronous tree-table reload completion. |
projects/composition/src/app/pages/tree-table-page/tree-table-page.component.html |
Binds loading state in the tree-table example. |
projects/composition/src/app/pages/table-page/table-page.examples.ts |
Updates the table code example with loading-state usage. |
projects/composition/src/app/pages/table-page/table-page.component.ts |
Simulates asynchronous table reload completion. |
projects/composition/src/app/pages/table-page/table-page.component.html |
Binds loading state in the table example. |
projects/composition/src/app/api-data/cps-tree-table.json |
Documents the new tree-table input. |
projects/composition/src/app/api-data/cps-table.json |
Documents the new table input. |
playwright/cps-ui-kit/components/cps-tree-table.spec.ts |
Verifies tree-table reload focus and loading behavior end to end. |
playwright/cps-ui-kit/components/cps-table.spec.ts |
Verifies table reload focus and loading behavior end to end. |
Review effort: Lite
Contributor
Coverage report for library
Test suite run success3248 tests passing in 76 suites. Report generated by 🧪jest coverage report action from cb346c6 |
Contributor
Playwright test results
Details
|
lukasmatta
approved these changes
Oct 28, 2026
fateeand
deleted the
895-table-tree-table-add-datareloadbtnloading-input-so-the-reload-button-keeps-focus-while-data-loads
branch
October 29, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a
dataReloadBtnLoadinginput toCpsTableComponentandCpsTreeTableComponent, and passed it to the toolbar reload button as[loading]. While it istrue, the native button stays enabled, so it keeps keyboard focus and its focus ring. It ignores clicks and Enter, hasaria-busy="true"and shows the loading spinner. Until now apps could only setdataReloadBtnDisabled, which disabled the button, so focus fell back to<body>until the data arrived.Closes #895
Release notes:
dataReloadBtnLoadinginput to table and tree table so the reload button keeps keyboard focus while data reloads