Repository navigation
A power of a product with a sum in it is multiplied out as a polynomial - #1854
Merged
Rafael-SOWNet merged 3 commits intoOct 12, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
…modulo-a-quadratic-power
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #718.
A power of a product with a sum in it is multiplied out as a polynomial. In
ExpandedOverTheSymbols, the fast path, which multiplies out over the symbols as a polynomial, was taken only for a sum raised to a power or a product with sums on both sides. Beside(d + k x)^3, the norm of the other factors' residue modulo a repeated quadratic is(S c)^2, whereShas 28 terms. That is neither shape, so it went toEntity.Expand. That one expansion took 27 of the 29 seconds of1/((d + k x)^3 (a + b x + c x^2)^2). The check now accepts a whole power of anything that contains a sum.1/((d + k x)^3 (a + b x + c x^2)^2)1/((d + k x)(f + g x)(a + b x + c x^2)^2)Measured against master 52ce4d8
SymbolicFactorsPartialFractionsTestgains a row that differentiates the first integral back and bounds its size.The other timeouts in 1.2.1.2, with the quadratic to the fourth and fifth power, are a different cost and are not addressed here.
🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura