Skip to content

Bugfix for Pandas 3.1 - #151

Merged
mcw92 merged 1 commit into
mainfrom
maintenance/tolerant-preprocessing-test
Oct 21, 2026
Merged

mcw92 merged 1 commit into
mainfrom
maintenance/tolerant-preprocessing-test

Conversation

@kalebphipps

Copy link
Copy Markdown
Member

Description

Pandas 3.1 (not yet release, but the pypi-test action uses --pre`` therefore it was tested on the test-release` branch) changes hour floating point numbers are read and considers a higher accuracy. This caused tests to fail since the pd.Dataframe now contains additional decimal points. Setting the tolerance solves the issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kalebphipps
kalebphipps requested a review from mcw92 October 21, 2026 09:39
@kalebphipps kalebphipps self-assigned this Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.67%. Comparing base (b80ae83) to head (42d808b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          26       26           
  Lines        1435     1435           
=======================================
  Hits         1416     1416           
  Misses         19       19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Name Stmts Miss Cover Missing
paint/__init__.py 9 0 100%
paint/data/dataset.py 82 1 99% 18
paint/data/dataset_splits.py 155 1 99% 51
paint/preprocessing/__init__.py 15 0 100%
paint/preprocessing/binary_extractor.py 54 1 98% 84
paint/preprocessing/calibration_stac.py 10 0 100%
paint/preprocessing/catalog_stac.py 4 0 100%
paint/preprocessing/deflectometry_stac.py 10 0 100%
paint/preprocessing/dwd_mappings.py 14 0 100%
paint/preprocessing/dwd_stac_item.py 5 0 100%
paint/preprocessing/dwd_weather.py 46 1 98% 102
paint/preprocessing/focal_spot_extractor.py 93 5 95% 85, 92, 116, 273, 320
paint/preprocessing/heliostat_catalog_stac.py 19 2 89% 40, 48
paint/preprocessing/juelich_weather_converter.py 51 3 94% 59, 111-114
paint/preprocessing/juelich_weather_mappings.py 34 0 100%
paint/preprocessing/juelich_weather_stac_item.py 6 0 100%
paint/preprocessing/properties_stac.py 11 0 100%
paint/preprocessing/target_cropper.py 54 1 98% 205
paint/preprocessing/tower_measurements.py 48 0 100%
paint/preprocessing/tower_stac.py 5 0 100%
paint/preprocessing/weather_collection_stac.py 5 0 100%
paint/util/__init__.py 28 0 100%
paint/util/gauss_kruger_converter.py 9 0 100%
paint/util/paint_mappings.py 591 0 100%
paint/util/preprocessing.py 32 0 100%
paint/util/utils.py 45 5 89% 136-141
TOTAL 1435 20 99%

@mcw92
mcw92 merged commit 63d1839 into main Oct 21, 2026
12 checks passed
@mcw92
mcw92 deleted the maintenance/tolerant-preprocessing-test branch October 21, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants