Repository navigation
Faster loading and saving of large scenarios - #233
Merged
Merged
Conversation
Reverts 50968be, which undid these changes on main after they were pushed there by mistake. They now come back through a pull request.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 96.41% 96.93% +0.51%
==========================================
Files 57 58 +1
Lines 4245 4496 +251
==========================================
+ Hits 4093 4358 +265
+ Misses 152 138 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MarleneBusch
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most of the slow loading seems to be going into evaluating the NURBS surface of every heliostat one at a time (twice, once for points and once for normals), plus reading and copying every value of every heliostat to the device individually.
This PR aims to improve this without any changes for existing user code: the same functions are called with the same arguments.
NOTE: I have given this code a brief review, but we should test it on the cluster first and review in detail before merging
Key Changes
Loading
surface_evaluation_chunk_sizeargument ofScenario.load_scenario_from_hdf5()(default 1024) if device memory is tight.New columnar layout for heliostats
H5ScenarioGeneratornow stores the heliostats column-wise: one dataset per parameter for all heliostats, instead of one group per heliostat. The rest of the scenario file (tower, light sources, prototypes) is unchanged.artist.io.convert_scenario_to_columnar(old_path, new_path).Type of change
Checklist: