Repository navigation
log_parser: Fix IndexError in parse_resv_mem_map() on ERROR lines - #824
Merged
chetan-rathore merged 1 commit intoOct 29, 2026
Conversation
reserved_memory_map_checker.py prints both INFO (pass) and ERROR
(fail) lines containing the substring "fully covered":
INFO: Reserved-memory range ... is fully covered by ...
ERROR: Reserved-memory range ... is not fully covered by ...
parse_resv_mem_map() matched on "fully covered" alone, so ERROR
lines also entered the INFO-only branch, where
line.split("INFO:", 1)[1] raised IndexError (no "INFO:" substring
to split on). This crashed logs_to_json.py and made the
RESERVED_MEMORY_MAP suite get reported as "not run" instead of its
actual result.
Restrict the match to lines starting with "INFO:" so only pass-case
lines take this path. ERROR lines are unaffected and continue to be
captured by the existing line.startswith("ERROR: Reserved-memory")
check above.
Signed-off-by: Shubham Singh <shubna@qti.qualcomm.com>
chetan-rathore
left a comment
chetan-rathore
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution.
chetan-rathore
approved these changes
Oct 29, 2026
chetan-rathore
left a comment
chetan-rathore
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reserved_memory_map_checker.py prints both INFO (pass) and ERROR (fail) lines containing the substring "fully covered":
INFO: Reserved-memory range ... is fully covered by ...
ERROR: Reserved-memory range ... is not fully covered by ...
parse_resv_mem_map() matched on "fully covered" alone, so ERROR lines also entered the INFO-only branch, where
line.split("INFO:", 1)[1] raised IndexError (no "INFO:" substring to split on). This crashed logs_to_json.py and made the RESERVED_MEMORY_MAP suite get reported as "not run" instead of its actual result.
Restrict the match to lines starting with "INFO:" so only pass-case lines take this path. ERROR lines are unaffected and continue to be captured by the existing line.startswith("ERROR: Reserved-memory") check above.