Repository navigation
hrx: pass logical row through shared F32 dequant reader - #187
Closed
AaronStGeorge wants to merge 1 commit into
Closed
AaronStGeorge wants to merge 1 commit into
AaronStGeorge wants to merge 1 commit into
Conversation
Assisted-by: Codex
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Pass the logical row into the shared F32 dequant reader so row64 Q4/Q6 addressing uses the same operation and vector loop as standard-layout readers. Update its callers while preserving the shared F16 interface.
This is fix 1/5 in the row64 stack following #181. Stacks on #181; base branch:
users/astgeorg/p6dm24-qwen27-pr171-restored-20261104. Commit:826b09be989b4c7d5811d6a3525097ef071cd0fe. Keep each fix as a separate stacked PR.Validation
Scalar references and ordinary Q4/native Q6/tiled controls passed. The inspected Q4/Q6 decode code matches the direct-reader control.
The complete stack at
bd85479285423b239213519d0892c56d071864dfwas measured against frozen integrationbe335351871563a09520b0db4a63c21db2040807with standalone llama-bench. The final fifteen-model table and separate Qwen3-0.6B stability result are in #181; those combined-stack results are not isolated gains from this commit.Requirements