Repository navigation
adding functionality for cox regression - #88
Open
mahaalbashir wants to merge 1 commit into
Open
mahaalbashir wants to merge 1 commit into
mahaalbashir wants to merge 1 commit into
Conversation
jim-smith
reviewed
Oct 20, 2026
| } | ||
|
|
||
| #' Fits a Cox proportional hazards regression model | ||
| #' |
Collaborator
There was a problem hiding this comment.
Is this function signature the same as the original R one?
jim-smith
reviewed
Oct 20, 2026
jim-smith
left a comment
jim-smith
left a comment
Collaborator
There was a problem hiding this comment.
Minor question: looks ike you have replicated the underlying R function.
Q1 are there options/capabilities that lifelines supports that R doesn't - which arse being denied to R users by the design choice above?
Q2 how much of the R survival::cxoxph functionality are we not able to replicate?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the cox proportional hazards functionality