From d4bd3d5dc4ac3d9cf059365b4cffdfd6cb3160f9 Mon Sep 17 00:00:00 2001 From: Steven Enamakel Date: Sat, 14 Nov 2026 00:12:53 +0000 Subject: [PATCH 1/2] ci: pin rust toolchain to 1.99.1 in ci and release workflows Rust 1.100.0 instruments more lines in the same code, which dropped per-file coverage below the 90% gate with no source change. Pinning the toolchain keeps the gate stable until it can be moved deliberately alongside the coverage threshold. Auto-committed-on: cuttlefish Co-authored-by: Medulla --- .github/workflows/ci.yml | 6 +++++- .github/workflows/release.yml | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5fa8803e..23a60633 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,7 +45,11 @@ jobs: if: ${{ runner.os == 'Linux' }} run: sudo apt-get update && sudo apt-get install --yes libdbus-1-dev - - uses: dtolnay/rust-toolchain@stable + # Pinned: the 90% per-file coverage gate below counts lines as this + # toolchain's llvm-cov does. Rust 1.100.0 counts more lines in the same + # code (adapter.rs 2546 -> 2472 instrumented, 92.8% -> 88.5%) and failed + # the gate with no source change. Move it deliberately, with the gate. + - uses: dtolnay/rust-toolchain@1.99.1 with: components: rustfmt, clippy, llvm-tools-preview diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 369a1ed8..2153f675 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -45,7 +45,11 @@ jobs: - name: Install Linux Secret Service build dependency run: sudo apt-get update && sudo apt-get install --yes libdbus-1-dev - - uses: dtolnay/rust-toolchain@stable + # Pinned: the 90% per-file coverage gate below counts lines as this + # toolchain's llvm-cov does. Rust 1.100.0 counts more lines in the same + # code (adapter.rs 2546 -> 2472 instrumented, 92.8% -> 88.5%) and failed + # the gate with no source change. Move it deliberately, with the gate. + - uses: dtolnay/rust-toolchain@1.99.1 with: components: rustfmt, clippy From f81d4bbde2e5102823c2efef0d09ed443b79b50a Mon Sep 17 00:00:00 2001 From: Steven Enamakel Date: Sat, 14 Nov 2026 00:13:01 +0000 Subject: [PATCH 2/2] ci: pin the coverage jobs' toolchain to 1.99.1 Co-authored-by: Medulla --- .github/workflows/ci.yml | 4 ++-- .github/workflows/release.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 23a60633..3ac514a4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -46,8 +46,8 @@ jobs: run: sudo apt-get update && sudo apt-get install --yes libdbus-1-dev # Pinned: the 90% per-file coverage gate below counts lines as this - # toolchain's llvm-cov does. Rust 1.100.0 counts more lines in the same - # code (adapter.rs 2546 -> 2472 instrumented, 92.8% -> 88.5%) and failed + # toolchain's llvm-cov does. Rust 1.100.0 counts the same code differently + # (adapter.rs: 2546 -> 2472 lines, 92.8% -> 88.5% covered) and failed # the gate with no source change. Move it deliberately, with the gate. - uses: dtolnay/rust-toolchain@1.99.1 with: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2153f675..e155c78e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -46,8 +46,8 @@ jobs: run: sudo apt-get update && sudo apt-get install --yes libdbus-1-dev # Pinned: the 90% per-file coverage gate below counts lines as this - # toolchain's llvm-cov does. Rust 1.100.0 counts more lines in the same - # code (adapter.rs 2546 -> 2472 instrumented, 92.8% -> 88.5%) and failed + # toolchain's llvm-cov does. Rust 1.100.0 counts the same code differently + # (adapter.rs: 2546 -> 2472 lines, 92.8% -> 88.5% covered) and failed # the gate with no source change. Move it deliberately, with the gate. - uses: dtolnay/rust-toolchain@1.99.1 with: