From 4005e7b75e807938b91bfee124aa00f9c1a86b00 Mon Sep 17 00:00:00 2001 From: Dave Cheney Date: Wed, 11 Nov 2026 22:03:10 +1100 Subject: [PATCH] epd1in54: set the RAM address before each frame write After LDirInit the image was one row lower than the buffer, and the top row was drawn on the bottom edge of the panel. LDirInit set the RAM address counter while the display was busy, so the controller ignored it. Set the RAM X and Y address counters before each RAM write. --- waveshare-epd/epd1in54/epd1in54.go | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/waveshare-epd/epd1in54/epd1in54.go b/waveshare-epd/epd1in54/epd1in54.go index 120b356ef..8fde38df0 100644 --- a/waveshare-epd/epd1in54/epd1in54.go +++ b/waveshare-epd/epd1in54/epd1in54.go @@ -28,8 +28,9 @@ type Device struct { rst machine.Pin busy machine.Pin - buffer []uint8 - rotation Rotation + buffer []uint8 + rotation Rotation + yDecrement bool } type Rotation uint8 @@ -91,6 +92,7 @@ func New(bus *machine.SPI, csPin, dcPin, rstPin, busyPin machine.Pin) Device { } func (d *Device) LDirInit(cfg Config) { + d.yDecrement = false d.cs.Configure(machine.PinConfig{Mode: machine.PinOutput}) d.rst.Configure(machine.PinConfig{Mode: machine.PinOutput}) d.dc.Configure(machine.PinConfig{Mode: machine.PinOutput}) @@ -142,7 +144,7 @@ func (d *Device) LDirInit(cfg Config) { d.SendData(0x00) d.SendCommand(0x4F) - d.SendData(0xC7) + d.SendData(0x00) d.SendData(0x00) d.WaitUntilIdle() @@ -150,6 +152,7 @@ func (d *Device) LDirInit(cfg Config) { } func (d *Device) HDirInit(cfg Config) { + d.yDecrement = true d.cs.Configure(machine.PinConfig{Mode: machine.PinOutput}) d.rst.Configure(machine.PinConfig{Mode: machine.PinOutput}) d.dc.Configure(machine.PinConfig{Mode: machine.PinOutput}) @@ -287,6 +290,7 @@ func (d *Device) DisplayImage(image []uint8) { } h = int(Height) + d.setCursor() d.SendCommand(0x24) for j := 0; j < h; j++ { for i := 0; i < w; i++ { @@ -294,6 +298,7 @@ func (d *Device) DisplayImage(image []uint8) { } } + d.setCursor() d.SendCommand(0x26) for j := 0; j < h; j++ { for i := 0; i < w; i++ { @@ -313,6 +318,7 @@ func (d *Device) Display() error { } h = int(Height) + d.setCursor() d.SendCommand(0x24) for j := 0; j < h; j++ { for i := 0; i < w; i++ { @@ -321,6 +327,7 @@ func (d *Device) Display() error { } } + d.setCursor() d.SendCommand(0x26) for j := 0; j < h; j++ { for i := 0; i < w; i++ { @@ -334,6 +341,19 @@ func (d *Device) Display() error { return nil } +// setCursor moves the RAM address counter to the first byte of the frame. +func (d *Device) setCursor() { + d.SendCommand(0x4E) + d.SendData(0x00) + d.SendCommand(0x4F) + if d.yDecrement { + d.SendData(0xC7) + } else { + d.SendData(0x00) + } + d.SendData(0x00) +} + func (d *Device) displayFrame() { d.SendCommand(0x22) d.SendData(0xC7) @@ -350,6 +370,7 @@ func (d *Device) Clear() { } h = int(Height) + d.setCursor() d.SendCommand(0x24) for j := 0; j < h; j++ { for i := 0; i < w; i++ { @@ -357,6 +378,7 @@ func (d *Device) Clear() { } } + d.setCursor() d.SendCommand(0x26) for j := 0; j < h; j++ { for i := 0; i < w; i++ {