Repository navigation
Expand file tree
/
Copy pathCampaignBatchTest.java
More file actions
554 lines (525 loc) · 33.3 KB
/
Copy pathCampaignBatchTest.java
File metadata and controls
554 lines (525 loc) · 33.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
package dev.jinhyeon.notificationlab.campaign.batch;
import com.github.dockerjava.api.model.PortBinding;
import com.github.dockerjava.api.model.Ports;
import dev.jinhyeon.notificationlab.NotificationLabApplication;
import dev.jinhyeon.notificationlab.campaign.Campaign;
import dev.jinhyeon.notificationlab.campaign.CampaignRequest;
import dev.jinhyeon.notificationlab.campaign.CampaignService;
import dev.jinhyeon.notificationlab.campaign.SyntheticCampaignAudience;
import dev.jinhyeon.notificationlab.config.AsyncProperties;
import dev.jinhyeon.notificationlab.config.TrafficRouting;
import dev.jinhyeon.notificationlab.outbox.OutboxRelay;
import dev.jinhyeon.notificationlab.outbox.OutboxStore;
import io.micrometer.core.instrument.MeterRegistry;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.sql.DriverManager;
import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.TimeZone;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.AfterAll;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;
import org.apache.kafka.clients.admin.Admin;
import org.apache.kafka.clients.admin.OffsetSpec;
import org.apache.kafka.common.TopicPartition;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.springframework.batch.core.BatchStatus;
import org.springframework.batch.core.JobExecution;
import org.springframework.batch.core.explore.JobExplorer;
import org.springframework.batch.core.repository.JobExecutionAlreadyRunningException;
import org.springframework.batch.item.Chunk;
import org.springframework.boot.WebApplicationType;
import org.springframework.boot.builder.SpringApplicationBuilder;
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.core.io.ClassPathResource;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.kafka.core.KafkaTemplate;
import org.springframework.kafka.support.SendResult;
import org.springframework.transaction.PlatformTransactionManager;
import org.springframework.transaction.support.TransactionTemplate;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.MySQLContainer;
import org.testcontainers.junit.jupiter.Container;
import org.testcontainers.junit.jupiter.Testcontainers;
import org.testcontainers.kafka.KafkaContainer;
import org.testcontainers.utility.DockerImageName;
import redis.clients.jedis.Jedis;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.awaitility.Awaitility.await;
@Testcontainers
class CampaignBatchTest {
@Container
static final MySQLContainer<?> MYSQL = new MySQLContainer<>("mysql:8.4.8")
.withDatabaseName("notification_lab").withUsername("notification_test")
.withPassword(UUID.randomUUID().toString()).withCommand("--default-time-zone=+00:00")
.withUrlParam("connectionTimeZone", "UTC").withUrlParam("forceConnectionTimeZoneToSession", "true")
.withCreateContainerCmdModifier(cmd -> cmd.getHostConfig().withPortBindings(
Arrays.stream(cmd.getExposedPorts()).map(port ->
new PortBinding(Ports.Binding.bindIpAndPort("127.0.0.1", 0), port)).toList()));
@Container
static final KafkaContainer KAFKA = new KafkaContainer(DockerImageName.parse("apache/kafka:4.0.2"))
.withEnv("KAFKA_HEAP_OPTS", "-Xms256m -Xmx512m")
.withCreateContainerCmdModifier(cmd -> cmd.getHostConfig().withPortBindings(
Arrays.stream(cmd.getExposedPorts()).map(port ->
new PortBinding(Ports.Binding.bindIpAndPort("127.0.0.1", 0), port)).toList()));
@Container
static final GenericContainer<?> REDIS = new GenericContainer<>("redis:7.4.11-alpine").withExposedPorts(6379)
.withCreateContainerCmdModifier(cmd -> cmd.getHostConfig().withPortBindings(
Arrays.stream(cmd.getExposedPorts()).map(port ->
new PortBinding(Ports.Binding.bindIpAndPort("127.0.0.1", 0), port)).toList()));
private static TimeZone originalZone;
@BeforeAll
static void useUtcMetadata() {
originalZone = TimeZone.getDefault();
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
}
@AfterAll
static void restoreZone() { TimeZone.setDefault(originalZone); }
private final List<ConfigurableApplicationContext> contexts = new ArrayList<>();
private ConfigurableApplicationContext app;
private String url;
private String topic;
private String quotaKey;
@BeforeEach
void isolate() throws Exception {
String suffix = UUID.randomUUID().toString().replace("-", "");
String database = "batch_" + suffix;
try (var connection = DriverManager.getConnection(MYSQL.getJdbcUrl(), "root", MYSQL.getPassword());
var statement = connection.createStatement()) {
statement.execute("CREATE DATABASE " + database);
statement.execute("GRANT ALL ON " + database + ".* TO 'notification_test'@'%'");
}
url = MYSQL.getJdbcUrl().replace("/notification_lab", "/" + database);
topic = "batch-" + suffix; quotaKey = "test:batch:" + suffix;
try (Jedis redis = new Jedis("127.0.0.1", REDIS.getMappedPort(6379), 3000)) {
redis.eval(new ClassPathResource("redis/initialize-split-quota.lua").getContentAsString(StandardCharsets.UTF_8),
List.of(quotaKey), List.of("100", "100", "50", "50"));
}
app = application(false);
}
private ConfigurableApplicationContext application(boolean worker) {
var context = new SpringApplicationBuilder(NotificationLabApplication.class).web(WebApplicationType.NONE).run(
"--app.campaign.batch.enabled=true", "--app.campaign.batch.chunk-size=3",
"--app.traffic.lane=CAMPAIGN", "--app.traffic.split-enabled=true",
"--app.rate-limit.client-enabled=true", "--app.async.worker-enabled=" + worker,
"--app.async.relay-enabled=false", "--app.mock.delay-ms=0",
"--spring.datasource.url=" + url, "--spring.datasource.username=" + MYSQL.getUsername(),
"--spring.datasource.password=" + MYSQL.getPassword(), "--spring.kafka.bootstrap-servers=" + KAFKA.getBootstrapServers(),
"--app.async.topic=" + topic, "--app.async.group=" + topic,
"--app.rate-limit.port=" + REDIS.getMappedPort(6379), "--app.rate-limit.key=" + quotaKey,
"--app.rate-limit.rate-per-second=100", "--app.rate-limit.burst=100",
"--app.traffic.campaign-rate=50", "--app.traffic.campaign-burst=50",
"--logging.level.root=WARN", "--spring.main.banner-mode=off");
contexts.add(context);
return context;
}
@Test
void failedSecondChunkRollsBackAndNewContextRestartsSameInstanceAtCommittedKey() throws Exception {
Campaign campaign = requested(7);
root("CREATE TRIGGER fail_target BEFORE INSERT ON campaign_target FOR EACH ROW BEGIN IF NEW.target_ordinal = 5 THEN SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'secret-campaign-payload'; END IF; END");
JobExecution failed;
try { failed = run(campaign); } finally { root("DROP TRIGGER fail_target"); }
assertThat(failed.getStatus()).isEqualTo(BatchStatus.FAILED);
assertRows(3);
assertThat(checkpoint(failed)).isEqualTo(3);
assertThat(failed.getExitStatus().getExitDescription()).doesNotContain("secret-campaign-payload");
assertThat(failed.getStepExecutions()).allSatisfy(step ->
assertThat(step.getExitStatus().getExitDescription()).doesNotContain("secret-campaign-payload"));
app.close(); app = application(false);
var resumed = run(campaign);
assertThat(resumed.getStatus()).isEqualTo(BatchStatus.COMPLETED);
assertThat(resumed.getJobInstance().getInstanceId()).isEqualTo(failed.getJobInstance().getInstanceId());
assertThat(resumed.getId()).isNotEqualTo(failed.getId());
assertThat(resumed.getStepExecutions()).allSatisfy(step -> assertThat(step.getReadCount()).isEqualTo(4));
assertThat(checkpoint(resumed)).isEqualTo(7);
assertRows(7);
assertThat(run(campaign).getId()).isEqualTo(resumed.getId());
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_INSTANCE", Integer.class)).isEqualTo(1);
assertThat(endOffset()).isZero();
assertThat(db().queryForObject("SELECT COUNT(*) FROM outbox_event WHERE status='PENDING'", Integer.class)).isEqualTo(7);
assertIdentities(campaign);
System.out.println("CAMPAIGN_BATCH_RESTART checkpoint=3 resumedRead=4 finalTargets=7 instances=1 executions=2 kafkaRecords=0");
}
@Test
void checkpointStorageFailureRollsBackBusinessRowsWithTheChunk() throws Exception {
Campaign campaign = requested(7);
root("CREATE TRIGGER fail_checkpoint BEFORE UPDATE ON BATCH_STEP_EXECUTION_CONTEXT FOR EACH ROW BEGIN IF EXISTS(SELECT 1 FROM campaign_target WHERE target_ordinal = 4) THEN SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'checkpoint failure'; END IF; END");
JobExecution failed;
try { failed = run(campaign); } finally { root("DROP TRIGGER fail_checkpoint"); }
assertThat(failed.getStatus()).isEqualTo(BatchStatus.FAILED);
assertRows(3);
assertThat(checkpoint(failed)).isEqualTo(3);
assertThat(run(campaign).getStatus()).isEqualTo(BatchStatus.COMPLETED);
assertRows(7);
}
@Test
void repositoryRejectsSecondApplicationWhileSameInstanceIsRunning() throws Exception {
Campaign campaign = requested(6);
var second = application(false);
root("CREATE TRIGGER slow_target BEFORE INSERT ON campaign_target FOR EACH ROW DO SLEEP(0.2)");
try (var executor = Executors.newSingleThreadExecutor()) {
var firstRun = executor.submit(() -> run(campaign));
await().atMost(Duration.ofSeconds(5)).until(() ->
db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_EXECUTION WHERE STATUS='STARTED'", Integer.class) == 1);
assertThatThrownBy(() -> second.getBean(CampaignBatchService.class).execute(campaign.campaignId()))
.isInstanceOf(JobExecutionAlreadyRunningException.class);
assertThat(firstRun.get(10, TimeUnit.SECONDS).getStatus()).isEqualTo(BatchStatus.COMPLETED);
} finally { root("DROP TRIGGER slow_target"); }
assertRows(6);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_EXECUTION", Integer.class)).isEqualTo(1);
}
@Test
void ackUncertaintyDuplicatesKafkaRecordButNotDurableWorkOrProviderAttempt() throws Exception {
Campaign campaign = requested(2);
var execution = run(campaign);
assertThat(execution.getStatus()).isEqualTo(BatchStatus.COMPLETED);
assertThat(checkpoint(execution)).isEqualTo(2);
assertRows(2);
var real = template();
var uncertainAck = new CompletableFuture<SendResult<String, String>>();
var brokerAck = new CompletableFuture<SendResult<String, String>>();
var gated = new KafkaTemplate<String, String>(real.getProducerFactory()) {
@Override
public CompletableFuture<SendResult<String, String>> send(String name, String key, String value) {
real.send(name, key, value).whenComplete((result, error) -> {
if (error != null) brokerAck.completeExceptionally(error); else brokerAck.complete(result);
});
return uncertainAck;
}
};
try (var executor = Executors.newSingleThreadExecutor()) {
var relay = executor.submit(() -> relay(gated).relay());
brokerAck.get(5, TimeUnit.SECONDS);
assertThat(endOffset()).isEqualTo(1);
assertThat(db().queryForObject("SELECT COUNT(*) FROM outbox_event WHERE status='PUBLISHED'", Integer.class)).isZero();
assertThat(db().queryForObject("SELECT COUNT(*) FROM outbox_event WHERE status='PROCESSING'", Integer.class)).isEqualTo(1);
uncertainAck.completeExceptionally(new java.util.concurrent.TimeoutException("test ACK uncertainty"));
relay.get(5, TimeUnit.SECONDS);
} finally { uncertainAck.completeExceptionally(new IllegalStateException("test cleanup")); }
db().update("UPDATE outbox_event SET available_at=UTC_TIMESTAMP(6)");
relay(real).relay();
assertThat(endOffset()).isEqualTo(3);
assertThat(db().queryForObject("SELECT COUNT(*) FROM outbox_event WHERE status='PUBLISHED'", Integer.class)).isEqualTo(2);
var worker = application(true);
await().atMost(Duration.ofSeconds(20)).until(() ->
db().queryForObject("SELECT COUNT(*) FROM notification WHERE status='PROVIDER_ACCEPTED'", Integer.class) == 2
&& committedOffset(worker) == 3);
assertThat(db().queryForObject("SELECT COUNT(*) FROM delivery_attempt", Integer.class)).isEqualTo(2);
var tx = new TransactionTemplate(app.getBean(PlatformTransactionManager.class));
tx.executeWithoutResult(status -> new CampaignTargetWriter(campaign, db(), 3)
.write(new Chunk<>(SyntheticCampaignAudience.read(campaign, 0, 2).items())));
assertRows(2);
assertThat(db().queryForObject("SELECT COUNT(*) FROM notification WHERE status='PROVIDER_ACCEPTED'", Integer.class)).isEqualTo(2);
assertThat(db().queryForObject("SELECT COUNT(*) FROM outbox_event WHERE status='PUBLISHED'", Integer.class)).isEqualTo(2);
assertThat(db().queryForObject("SELECT COUNT(*) FROM delivery_attempt", Integer.class)).isEqualTo(2);
assertThat(endOffset()).isEqualTo(3);
System.out.println("CAMPAIGN_BATCH_ACK targets=2 kafkaRecords=3 published=2 providerAttempts=2 replayReset=0");
}
@Test
void explicitCommandRunsInSeparateJvmAndCompletedReplayDoesNotExpandAgain() throws Exception {
Campaign campaign = requested(4);
assertThat(command(campaign.campaignId())).isZero();
var created = db().queryForObject("SELECT CREATE_TIME FROM BATCH_JOB_EXECUTION", java.time.LocalDateTime.class);
assertThat(Duration.between(created.toInstant(java.time.ZoneOffset.UTC), java.time.Instant.now()).abs())
.isLessThan(Duration.ofMinutes(1));
assertRows(4);
assertThat(command(campaign.campaignId())).isZero();
assertRows(4);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_EXECUTION", Integer.class)).isEqualTo(1);
assertThat(endOffset()).isZero();
}
@Test
void draftAndUnknownCampaignsCannotCreateBatchExecutions() throws Exception {
Campaign draft = app.getBean(CampaignService.class).create(new CampaignRequest("draft", "title", "body", 2), UUID.randomUUID().toString()).campaign();
assertThatThrownBy(() -> run(draft)).isInstanceOf(IllegalStateException.class);
assertThatThrownBy(() -> app.getBean(CampaignBatchService.class).execute(UUID.randomUUID()))
.isInstanceOf(dev.jinhyeon.notificationlab.campaign.CampaignNotFoundException.class);
assertThat(command(draft.campaignId(), 1)).isEqualTo(1);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_INSTANCE", Integer.class)).isZero();
assertRows(0);
}
@Test
void killedJvmRecoversOnlyCommittedChunkInSameJobInstance() throws Exception {
Campaign campaign = requested(7);
root("CREATE TRIGGER slow_chunk BEFORE INSERT ON campaign_target FOR EACH ROW BEGIN IF NEW.target_ordinal = 4 THEN DO SLEEP(8); END IF; END");
Path output = Files.createTempFile("campaign-kill-", ".log");
Process process = startCommand(campaign.campaignId(), output);
try {
awaitFirstChunk();
long firstId = db().queryForObject("SELECT JOB_EXECUTION_ID FROM BATCH_JOB_EXECUTION", Long.class);
process.destroyForcibly();
assertThat(process.waitFor(5, TimeUnit.SECONDS)).isTrue();
await().atMost(Duration.ofSeconds(20)).until(() -> owner(campaign) == null);
root("DROP TRIGGER slow_chunk");
assertRows(3);
assertThat(db().queryForObject("SELECT STATUS FROM BATCH_JOB_EXECUTION", String.class)).isEqualTo("STARTED");
assertThat(command(campaign.campaignId())).isZero();
assertRows(7);
assertIdentities(campaign);
var old = app.getBean(JobExplorer.class).getJobExecution(firstId);
assertThat(old.getStatus()).isEqualTo(BatchStatus.FAILED);
assertThat(checkpoint(old)).isEqualTo(3);
assertThat(old.getExitStatus().getExitDescription()).contains("exclusive MySQL session");
var resumed = app.getBean(JobExplorer.class).getJobExecution(run(campaign).getId());
assertThat(resumed.getStepExecutions()).hasSize(1);
assertThat(resumed.getJobInstance().getId()).isEqualTo(old.getJobInstance().getId());
assertThat(resumed.getStepExecutions()).allSatisfy(step -> assertThat(step.getReadCount()).isEqualTo(4));
assertThat(checkpoint(resumed)).isEqualTo(7);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_EXECUTION", Integer.class)).isEqualTo(2);
assertThat(endOffset()).isZero();
System.out.println("CAMPAIGN_BATCH_KILL checkpoint=3 resumedRead=4 finalTargets=7 instances=1 executions=2");
} finally {
if (process.isAlive()) { process.destroyForcibly(); process.waitFor(5, TimeUnit.SECONDS); }
Files.deleteIfExists(output);
}
}
@Test
void pausedOldJvmCannotWriteBusinessOrMetadataAfterItsMysqlSessionIsKilled() throws Exception {
Campaign campaign = requested(7);
root("CREATE TRIGGER slow_chunk BEFORE INSERT ON campaign_target FOR EACH ROW BEGIN IF NEW.target_ordinal = 4 THEN DO SLEEP(15); END IF; END");
Path output = Files.createTempFile("campaign-stale-owner-", ".log");
Process process = startCommand(campaign.campaignId(), output);
try {
awaitFirstChunk();
long ownerId = owner(campaign);
signal(process, "-STOP");
// Paused does not mean dead. A live MySQL session must block takeover, irrespective of age.
assertThatThrownBy(() -> run(campaign)).isInstanceOf(JobExecutionAlreadyRunningException.class);
root("KILL CONNECTION " + ownerId);
await().atMost(Duration.ofSeconds(10)).until(() -> owner(campaign) == null);
root("DROP TRIGGER slow_chunk");
var resumed = run(campaign);
assertThat(resumed.getStatus()).isEqualTo(BatchStatus.COMPLETED);
assertThat(checkpoint(resumed)).isEqualTo(7);
var business = new java.util.LinkedHashMap<String, List<Map<String, Object>>>();
for (String table : List.of("notification", "delivery_task", "outbox_event", "campaign_target", "BATCH_JOB_EXECUTION_CONTEXT")) {
business.put(table, snapshot(table));
}
var jobs = db().queryForList("SELECT * FROM BATCH_JOB_EXECUTION ORDER BY JOB_EXECUTION_ID");
var steps = db().queryForList("SELECT * FROM BATCH_STEP_EXECUTION ORDER BY STEP_EXECUTION_ID");
var contextsBefore = db().queryForList("SELECT * FROM BATCH_STEP_EXECUTION_CONTEXT ORDER BY STEP_EXECUTION_ID");
signal(process, "-CONT");
assertThat(process.waitFor(40, TimeUnit.SECONDS)).isTrue();
assertThat(process.exitValue()).isEqualTo(1);
assertRows(7);
assertIdentities(campaign);
assertThat(db().queryForList("SELECT * FROM BATCH_JOB_EXECUTION ORDER BY JOB_EXECUTION_ID")).isEqualTo(jobs);
assertThat(db().queryForList("SELECT * FROM BATCH_STEP_EXECUTION ORDER BY STEP_EXECUTION_ID")).isEqualTo(steps);
assertThat(db().queryForList("SELECT * FROM BATCH_STEP_EXECUTION_CONTEXT ORDER BY STEP_EXECUTION_ID")).isEqualTo(contextsBefore);
for (var snapshot : business.entrySet()) {
assertThat(snapshot(snapshot.getKey())).as(snapshot.getKey())
.containsExactlyInAnyOrderElementsOf(snapshot.getValue());
}
assertThat(owner(campaign)).isNull();
System.out.println("CAMPAIGN_BATCH_FENCE pausedOwnerRejected=true staleExit=1 targets=7 metadataUnchanged=true");
} finally {
if (process.isAlive()) { signal(process, "-CONT"); process.destroyForcibly(); process.waitFor(5, TimeUnit.SECONDS); }
Files.deleteIfExists(output);
}
}
@Test
void legacyUncertainExecutionIsNeverReclassifiedWithoutOwnershipEvidence() throws Exception {
var campaign = requested(2);
var repository = app.getBean(org.springframework.batch.core.repository.JobRepository.class);
var parameters = new org.springframework.batch.core.JobParametersBuilder()
.addString("campaignId", campaign.campaignId().toString()).toJobParameters();
var legacy = repository.createJobExecution(CampaignBatchService.JOB_NAME, parameters);
for (var status : List.of(BatchStatus.STARTING, BatchStatus.UNKNOWN)) {
legacy.setStatus(status);
repository.update(legacy);
assertThatThrownBy(() -> run(campaign)).isInstanceOf(IllegalStateException.class)
.hasMessageContaining("Legacy execution ownership");
assertThat(db().queryForObject("SELECT STATUS FROM BATCH_JOB_EXECUTION", String.class)).isEqualTo(status.name());
assertThat(owner(campaign)).isNull();
}
assertRows(0);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_EXECUTION", Integer.class)).isEqualTo(1);
}
@Test
void unknownExecutionRecoveryIsAtomicAndPreservesCommittedCheckpoint() throws Exception {
var campaign = requested(7);
root("CREATE TRIGGER fail_target BEFORE INSERT ON campaign_target FOR EACH ROW BEGIN IF NEW.target_ordinal = 5 THEN SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'test failure'; END IF; END");
var failed = run(campaign);
root("DROP TRIGGER fail_target");
assertRows(3);
// Model an uncertain commit result recorded by the framework after loss of the original session.
db().update("UPDATE BATCH_JOB_EXECUTION SET STATUS='UNKNOWN', END_TIME=NULL");
db().update("UPDATE BATCH_STEP_EXECUTION SET STATUS='UNKNOWN', END_TIME=NULL");
var before = db().queryForList("SELECT * FROM BATCH_STEP_EXECUTION");
root("CREATE TRIGGER fail_recovery BEFORE UPDATE ON BATCH_JOB_EXECUTION FOR EACH ROW BEGIN IF NEW.STATUS = 'FAILED' THEN SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'recovery storage failure'; END IF; END");
try {
assertThatThrownBy(() -> run(campaign)).isInstanceOf(org.springframework.dao.DataAccessException.class);
assertThat(db().queryForList("SELECT * FROM BATCH_STEP_EXECUTION")).isEqualTo(before);
assertThat(db().queryForObject("SELECT STATUS FROM BATCH_JOB_EXECUTION", String.class)).isEqualTo("UNKNOWN");
assertRows(3);
assertThat(owner(campaign)).isNull();
} finally { root("DROP TRIGGER fail_recovery"); }
var resumed = run(campaign);
assertThat(resumed.getStatus()).isEqualTo(BatchStatus.COMPLETED);
assertThat(resumed.getJobInstance().getId()).isEqualTo(failed.getJobInstance().getId());
assertThat(resumed.getStepExecutions()).allSatisfy(step -> assertThat(step.getReadCount()).isEqualTo(4));
assertRows(7);
}
@Test
void reconnectingConnectionIsRejectedBeforeCreatingExecution() throws Exception {
var properties = new org.springframework.boot.autoconfigure.jdbc.DataSourceProperties();
properties.setUrl(url + "&autoReconnect=true");
properties.setUsername(MYSQL.getUsername());
properties.setPassword(MYSQL.getPassword());
var campaign = requested(1);
assertThatThrownBy(() -> CampaignBatchSession.open(properties, db().getDataSource(), campaign.campaignId()))
.isInstanceOf(IllegalArgumentException.class).hasMessageContaining("without reconnect");
assertThat(owner(campaign)).isNull();
assertRows(0);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_EXECUTION", Integer.class)).isZero();
}
@Test
void executionParameterFailureCannotCommitPartialInstanceOrExecution() throws Exception {
var campaign = requested(2);
root("CREATE TRIGGER fail_parameters BEFORE INSERT ON BATCH_JOB_EXECUTION_PARAMS FOR EACH ROW SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'parameter storage failure'");
try {
assertThatThrownBy(() -> run(campaign)).isInstanceOf(org.springframework.dao.DataAccessException.class);
for (String table : List.of("BATCH_JOB_INSTANCE", "BATCH_JOB_EXECUTION", "BATCH_JOB_EXECUTION_PARAMS", "BATCH_JOB_EXECUTION_CONTEXT")) {
assertThat(db().queryForObject("SELECT COUNT(*) FROM " + table, Integer.class)).as(table).isZero();
}
assertRows(0);
assertThat(owner(campaign)).isNull();
} finally { root("DROP TRIGGER fail_parameters"); }
assertThat(run(campaign).getStatus()).isEqualTo(BatchStatus.COMPLETED);
assertRows(2);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_INSTANCE", Integer.class)).isEqualTo(1);
}
@Test
void differentCampaignSessionsCanRunConcurrentlyWithoutSharingOwnership() throws Exception {
var first = requested(6);
var second = requested(6);
var other = application(false);
root("CREATE TRIGGER slow_target BEFORE INSERT ON campaign_target FOR EACH ROW DO SLEEP(0.2)");
try (var executor = Executors.newFixedThreadPool(2)) {
var firstRun = executor.submit(() -> run(first));
await().atMost(Duration.ofSeconds(5)).until(() -> owner(first) != null);
var secondRun = executor.submit(() -> other.getBean(CampaignBatchService.class).execute(second.campaignId()));
assertThat(firstRun.get(15, TimeUnit.SECONDS).getStatus()).isEqualTo(BatchStatus.COMPLETED);
assertThat(secondRun.get(15, TimeUnit.SECONDS).getStatus()).isEqualTo(BatchStatus.COMPLETED);
} finally { root("DROP TRIGGER slow_target"); }
assertRows(12);
assertIdentities(first);
assertIdentities(second);
assertThat(db().queryForObject("SELECT COUNT(*) FROM BATCH_JOB_INSTANCE", Integer.class)).isEqualTo(2);
assertThat(owner(first)).isNull();
assertThat(owner(second)).isNull();
}
private List<Map<String, Object>> snapshot(String table) {
var rows = db().queryForList("SELECT * FROM " + table);
// JDBC returns a fresh byte[] for VARBINARY on each read; compare its bytes, not object identity.
rows.forEach(row -> row.replaceAll((key, value) -> value instanceof byte[] bytes
? java.util.HexFormat.of().formatHex(bytes) : value));
return rows;
}
private void awaitFirstChunk() {
await().atMost(Duration.ofSeconds(40)).until(() ->
db().queryForObject("SELECT COUNT(*) FROM campaign_target", Integer.class) == 3);
}
private Long owner(Campaign campaign) {
return db().queryForObject("SELECT IS_USED_LOCK(?)", Long.class,
CampaignBatchSession.lockName(db().queryForObject("SELECT DATABASE()", String.class), campaign.campaignId()));
}
private void signal(Process process, String signal) throws Exception {
var command = new ProcessBuilder("kill", signal, Long.toString(process.pid())).start();
assertThat(command.waitFor(5, TimeUnit.SECONDS)).isTrue();
assertThat(command.exitValue()).isZero();
}
private int command(UUID id) throws Exception { return command(id, 0); }
private int command(UUID id, int expectedExit) throws Exception {
boolean expectedOutcome = false;
Path output = Files.createTempFile("campaign-command-", ".log");
Process process = startCommand(id, output);
try {
assertThat(process.waitFor(40, TimeUnit.SECONDS)).as("campaign command exited; log %s", output).isTrue();
assertThat(Files.readString(output)).contains("CAMPAIGN_BATCH");
expectedOutcome = process.exitValue() == expectedExit;
return process.exitValue();
} finally {
if (process.isAlive()) { process.destroyForcibly(); process.waitFor(5, TimeUnit.SECONDS); }
if (expectedOutcome) Files.deleteIfExists(output);
else {
Path reports = Files.createDirectories(Path.of("build/reports/campaign-command-failures"));
Path preserved = reports.resolve(output.getFileName());
Files.move(output, preserved);
System.out.println("CAMPAIGN_COMMAND_FAILURE log=" + preserved);
}
}
}
private Process startCommand(UUID id, Path output) throws Exception {
var builder = new ProcessBuilder(Path.of(System.getProperty("java.home"), "bin", "java").toString(),
"-cp", System.getProperty("notificationLab.testClasspath"), CampaignBatchCommand.class.getName(), id.toString());
builder.environment().putAll(Map.of("SPRING_DATASOURCE_URL", url, "SPRING_DATASOURCE_USERNAME", MYSQL.getUsername(),
"SPRING_DATASOURCE_PASSWORD", MYSQL.getPassword(), "SPRING_KAFKA_BOOTSTRAP_SERVERS", KAFKA.getBootstrapServers(),
"APP_ASYNC_TOPIC", topic, "APP_ASYNC_GROUP", topic, "LOGGING_LEVEL_ROOT", "WARN", "SPRING_MAIN_BANNER_MODE", "off", "APP_CAMPAIGN_BATCH_CHUNK_SIZE", "3"));
builder.redirectErrorStream(true).redirectOutput(output.toFile());
return builder.start();
}
private Campaign requested(int count) {
var service = app.getBean(CampaignService.class);
var campaign = service.create(new CampaignRequest("batch", "title", "synthetic body", count), UUID.randomUUID().toString()).campaign();
return service.start(campaign.campaignId()).campaign();
}
private JobExecution run(Campaign campaign) throws Exception { return app.getBean(CampaignBatchService.class).execute(campaign.campaignId()); }
private JdbcTemplate db() { return app.getBean(JdbcTemplate.class); }
private long checkpoint(JobExecution execution) {
return app.getBean(JobExplorer.class).getJobExecution(execution.getId()).getStepExecutions().iterator().next()
.getExecutionContext().getLong(CampaignTargetReader.CHECKPOINT);
}
private void assertRows(int count) {
for (String table : List.of("notification", "delivery_task", "outbox_event", "campaign_target")) {
assertThat(db().queryForObject("SELECT COUNT(*) FROM " + table, Integer.class)).as(table).isEqualTo(count);
}
}
private void assertIdentities(Campaign campaign) {
for (int ordinal = 1; ordinal <= campaign.targetCount(); ordinal++) {
var ids = CampaignTargetIds.of(campaign.campaignId(), ordinal);
assertThat(db().queryForMap("SELECT notification_id,task_id,event_id FROM campaign_target WHERE campaign_id=? AND target_ordinal=?",
campaign.campaignId().toString(), ordinal)).containsAllEntriesOf(Map.of("notification_id", ids.notificationId().toString(),
"task_id", ids.taskId().toString(), "event_id", ids.eventId().toString()));
}
}
private void root(String sql) throws Exception {
try (var connection = DriverManager.getConnection(url, "root", MYSQL.getPassword()); var statement = connection.createStatement()) { statement.execute(sql); }
}
@SuppressWarnings("unchecked")
private KafkaTemplate<String, String> template() { return (KafkaTemplate<String, String>) app.getBean(KafkaTemplate.class); }
private OutboxRelay relay(KafkaTemplate<String, String> kafka) {
return new OutboxRelay(app.getBean(OutboxStore.class), kafka, app.getBean(AsyncProperties.class),
app.getBean(MeterRegistry.class), app.getBean(TrafficRouting.class));
}
private long endOffset() throws Exception {
try (Admin admin = Admin.create(Map.of("bootstrap.servers", KAFKA.getBootstrapServers()))) {
String name = app.getBean(TrafficRouting.class).topic();
var ends = new java.util.HashMap<TopicPartition, OffsetSpec>();
admin.describeTopics(List.of(name)).allTopicNames().get(5, TimeUnit.SECONDS).get(name).partitions()
.forEach(partition -> ends.put(new TopicPartition(name, partition.partition()), OffsetSpec.latest()));
return admin.listOffsets(ends).all().get(5, TimeUnit.SECONDS).values().stream().mapToLong(info -> info.offset()).sum();
}
}
private long committedOffset(ConfigurableApplicationContext context) throws Exception {
try (Admin admin = Admin.create(Map.of("bootstrap.servers", KAFKA.getBootstrapServers()))) {
return admin.listConsumerGroupOffsets(context.getBean(TrafficRouting.class).group()).partitionsToOffsetAndMetadata()
.get(5, TimeUnit.SECONDS).values().stream().mapToLong(offset -> offset.offset()).sum();
}
}
@AfterEach
void close() {
for (int i = contexts.size() - 1; i >= 0; i--) contexts.get(i).close();
}
}