From d919d3801bef58797433a68547651577e26e8d1c Mon Sep 17 00:00:00 2001
From: Byungjin Park <posquit0.bj@gmail.com>
Date: Tue, 22 Sep 2026 23:40:20 +0900
Subject: [PATCH] fix(web.s3.delivery): build S3 metadata as JSON

`aws s3 sync --metadata` accepts either the `k=v,k=v` shorthand or JSON. The
shorthand parser treats `[`, `]`, `,` and `=` as syntax, so any value that
contains one of them fails parameter validation before the upload starts.

`github.actor` is `<app>[bot]` for GitHub App commits, which trips this on
every bot-authored delivery. Build the metadata with `jq --arg` instead so the
values are escaped, and pass the resulting JSON to the same `--metadata` flag.

No input, output, or behavioural change beyond the encoding of that one value.
---
 .github/actions/web.s3.delivery/action.yaml | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/.github/actions/web.s3.delivery/action.yaml b/.github/actions/web.s3.delivery/action.yaml
index da6e2e4..4202271 100644
--- a/.github/actions/web.s3.delivery/action.yaml
+++ b/.github/actions/web.s3.delivery/action.yaml
@@ -205,7 +205,25 @@ runs:
       META_BRANCH: ${{ env.SOURCE_BRANCH }}
       META_SHA: ${{ github.sha }}
     run: |
-      export UPLOAD_METADATA="github-repository=${META_REPOSITORY},github-author=${META_AUTHOR},git-branch=${META_BRANCH},git-sha=${META_SHA},deployed-at=$(date -u +%Y-%m-%dT%H:%M:%SZ)"
+      # Built as JSON rather than the `k=v,k=v` shorthand: the shorthand parser
+      # treats `[`, `]`, `,` and `=` as syntax, so a value containing any of them
+      # fails parameter validation. `github.actor` is `<app>[bot]` for GitHub App
+      # commits, which is the case that surfaced this. `jq --arg` escapes the
+      # values, and `--metadata` accepts JSON just as well as shorthand.
+      UPLOAD_METADATA="$(jq -nc \
+        --arg github_repository "${META_REPOSITORY}" \
+        --arg github_author "${META_AUTHOR}" \
+        --arg git_branch "${META_BRANCH}" \
+        --arg git_sha "${META_SHA}" \
+        --arg deployed_at "$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
+        '{
+          "github-repository": $github_repository,
+          "github-author": $github_author,
+          "git-branch": $git_branch,
+          "git-sha": $git_sha,
+          "deployed-at": $deployed_at
+        }')"
+      export UPLOAD_METADATA
 
       python3 "${GITHUB_ACTION_PATH}/scripts/upload.py"