From af128771fb15afdc851010dc84d2329da6eeee2e Mon Sep 17 00:00:00 2001 From: Nathan ter Bogt Date: Fri, 2 Oct 2026 11:28:02 +1300 Subject: [PATCH 1/2] API requires volumeName. We weren't passing it in --- cmd/skpr/filesystem/backup/create/command.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/cmd/skpr/filesystem/backup/create/command.go b/cmd/skpr/filesystem/backup/create/command.go index 23f4595..84830e0 100644 --- a/cmd/skpr/filesystem/backup/create/command.go +++ b/cmd/skpr/filesystem/backup/create/command.go @@ -10,11 +10,11 @@ var ( cmdLong = `Create a filesystem backup of an environment.` cmdExample = ` - # Create a filesystem backup of dev. - skpr filesystem backup create dev + # Create a public filesystem backup of dev. + skpr filesystem backup create dev public - # Create and wait for a filesystem backup. - skpr filesystem backup create dev --wait` + # Create and wait for a private filesystem backup. + skpr filesystem backup create dev private --wait` ) // NewCommand creates a new cobra.Command for 'create' sub command @@ -22,14 +22,15 @@ func NewCommand() *cobra.Command { command := v1create.Command{} cmd := &cobra.Command{ - Use: "create ", - Args: cobra.ExactArgs(1), + Use: "create ", + Args: cobra.ExactArgs(2), DisableFlagsInUseLine: true, Short: "Create a filesystem backup", Long: cmdLong, Example: cmdExample, RunE: func(cmd *cobra.Command, args []string) error { command.Environment = args[0] + command.VolumeName = args[1] return command.Run(cmd.Context()) }, } From fd07b23e21432b128ff51eaf15d567e21c65f194 Mon Sep 17 00:00:00 2001 From: Nathan ter Bogt Date: Fri, 2 Oct 2026 11:29:52 +1300 Subject: [PATCH 2/2] Improving documentation --- cmd/skpr/filesystem/backup/create/command.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/skpr/filesystem/backup/create/command.go b/cmd/skpr/filesystem/backup/create/command.go index 84830e0..73f2fd3 100644 --- a/cmd/skpr/filesystem/backup/create/command.go +++ b/cmd/skpr/filesystem/backup/create/command.go @@ -10,10 +10,10 @@ var ( cmdLong = `Create a filesystem backup of an environment.` cmdExample = ` - # Create a public filesystem backup of dev. + # Create a filesystem backup of public mount on dev. skpr filesystem backup create dev public - # Create and wait for a private filesystem backup. + # Create and wait for a filesystem backup of private mount. skpr filesystem backup create dev private --wait` )