From 75e5541deeac8c545cfc674f6b2300b8d5db86dc Mon Sep 17 00:00:00 2001 From: anshurajbisoyi98-ctrl Date: Sun, 4 Oct 2026 12:05:24 +0530 Subject: [PATCH 1/2] docs: clarify multiple IV curve requirement for Sandia fits --- docs/sphinx/source/whatsnew/v0.16.2.rst | 5 +++++ pvlib/ivtools/sdm/desoto.py | 4 ++++ pvlib/ivtools/sdm/pvsyst.py | 4 ++++ 3 files changed, 13 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index f704525a12..c7fc54dc7c 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -23,6 +23,10 @@ Enhancements Documentation ~~~~~~~~~~~~~ +* Clarify that :py:func:`pvlib.ivtools.sdm.fit_pvsyst_sandia` and + :py:func:`pvlib.ivtools.sdm.fit_desoto_sandia` require multiple IV curves. + (:issue:`1715`) + Testing ~~~~~~~ @@ -43,3 +47,4 @@ Maintenance Contributors ~~~~~~~~~~~~ +* :ghuser:`anshurajbisoyi98-ctrl` diff --git a/pvlib/ivtools/sdm/desoto.py b/pvlib/ivtools/sdm/desoto.py index a97db7d702..ea792b2598 100644 --- a/pvlib/ivtools/sdm/desoto.py +++ b/pvlib/ivtools/sdm/desoto.py @@ -221,6 +221,10 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): """ Estimate parameters for the De Soto module performance model. + Requires multiple IV curves measured at different effective irradiance + and cell temperature conditions. Each curve must have corresponding + effective irradiance and cell temperature data in ``ivcurves``. + Parameters ---------- ivcurves : dict diff --git a/pvlib/ivtools/sdm/pvsyst.py b/pvlib/ivtools/sdm/pvsyst.py index 343d278fe9..795d9608d5 100644 --- a/pvlib/ivtools/sdm/pvsyst.py +++ b/pvlib/ivtools/sdm/pvsyst.py @@ -25,6 +25,10 @@ def fit_pvsyst_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): """ Estimate parameters for the PVsyst module performance model. + Requires multiple IV curves measured at different effective irradiance + and cell temperature conditions. Each curve must have corresponding + effective irradiance and cell temperature data in ``ivcurves``. + Parameters ---------- ivcurves : dict From d0c2a5ef9b81a890128657e5001c79174e31b0a3 Mon Sep 17 00:00:00 2001 From: anshurajbisoyi98-ctrl Date: Sun, 4 Oct 2026 22:51:24 +0530 Subject: [PATCH 2/2] docs: remove redundant IV curve wording --- pvlib/ivtools/sdm/desoto.py | 3 +-- pvlib/ivtools/sdm/pvsyst.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/pvlib/ivtools/sdm/desoto.py b/pvlib/ivtools/sdm/desoto.py index ea792b2598..391558591f 100644 --- a/pvlib/ivtools/sdm/desoto.py +++ b/pvlib/ivtools/sdm/desoto.py @@ -222,8 +222,7 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): Estimate parameters for the De Soto module performance model. Requires multiple IV curves measured at different effective irradiance - and cell temperature conditions. Each curve must have corresponding - effective irradiance and cell temperature data in ``ivcurves``. + and cell temperature conditions. Parameters ---------- diff --git a/pvlib/ivtools/sdm/pvsyst.py b/pvlib/ivtools/sdm/pvsyst.py index 795d9608d5..309cc42799 100644 --- a/pvlib/ivtools/sdm/pvsyst.py +++ b/pvlib/ivtools/sdm/pvsyst.py @@ -26,8 +26,7 @@ def fit_pvsyst_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): Estimate parameters for the PVsyst module performance model. Requires multiple IV curves measured at different effective irradiance - and cell temperature conditions. Each curve must have corresponding - effective irradiance and cell temperature data in ``ivcurves``. + and cell temperature conditions. Parameters ----------