From 8d928d687d673221c04b7cd3d02e1d7cdb9fb216 Mon Sep 17 00:00:00 2001
From: Jessey Fransen <jesseyfransen@gmail.com>
Date: Mon, 28 Sep 2026 14:53:28 +0200
Subject: [PATCH] fix(video): fail probe when decoder reports failure

---
 wallr-core/examples/video_probe.rs | 37 +++++++++++++++++++++++++-----
 1 file changed, 31 insertions(+), 6 deletions(-)

diff --git a/wallr-core/examples/video_probe.rs b/wallr-core/examples/video_probe.rs
index 363f384..09a9f08 100644
--- a/wallr-core/examples/video_probe.rs
+++ b/wallr-core/examples/video_probe.rs
@@ -5,15 +5,16 @@
 //! Decodes the file for a few seconds and reports frame rate, timing, and the
 //! backend actually used - no Wayland or GPU required.
 
+use std::process::ExitCode;
 use std::time::{Duration, Instant};
-use wallr_core::video::{HwAccel, VideoDecoder};
+use wallr_core::video::{DecoderState, HwAccel, VideoDecoder};
 
-fn main() {
+fn main() -> ExitCode {
     let mut args = std::env::args().skip(1);
     let path = args.next().expect("usage: video_probe <video> [backend]");
     if path == "--capabilities" {
         print_capabilities();
-        return;
+        return ExitCode::SUCCESS;
     }
     let backend = match args.next().as_deref() {
         Some("vaapi") => HwAccel::Vaapi,
@@ -26,7 +27,7 @@ fn main() {
         Ok(d) => d,
         Err(e) => {
             eprintln!("failed to init decoder: {e}");
-            std::process::exit(1);
+            return ExitCode::FAILURE;
         }
     };
 
@@ -69,14 +70,38 @@ fn main() {
         "decoded {count} frames in {elapsed:?} ({fps:.1} fps, {} idle polls)",
         dropped
     );
+    let state = decoder.decoder_state();
     println!(
         "active backend: {} (state: {}, dropped frames: {})",
         decoder.hw_accel_in_use().name(),
-        decoder.decoder_state().name(),
+        state.name(),
         decoder.dropped_frames()
     );
     println!("fallback occurred: {}", decoder.fallback_occurred());
-    println!("result: {}", if count > 30 { "PASS" } else { "FAIL" });
+    let passed = probe_passed(count, state);
+    println!("result: {}", if passed { "PASS" } else { "FAIL" });
+    if passed {
+        ExitCode::SUCCESS
+    } else {
+        ExitCode::FAILURE
+    }
+}
+
+fn probe_passed(count: u64, state: DecoderState) -> bool {
+    count > 30 && state != DecoderState::Failed
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn failed_decoder_cannot_pass_after_producing_frames() {
+        assert!(!probe_passed(300, DecoderState::Failed));
+        assert!(!probe_passed(30, DecoderState::SoftwareActive));
+        assert!(probe_passed(31, DecoderState::SoftwareActive));
+        assert!(probe_passed(300, DecoderState::HardwareActive));
+    }
 }
 
 fn print_capabilities() {