Repository navigation
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
pimcore-deployments
marked this pull request as draft
October 21, 2026 20:16
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The pull flags are appropriate for the existing Docker commands, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Updates Docker commands in CI to pull fresh PHP base images for release and test builds.
Changes:
- Adds
--pullto test and release image builds. - Adds
--pull=alwayswhen detecting the PHP version for releases.
| File | Description |
|---|---|
.github/workflows/test.yml |
Pulls fresh base images during test builds. |
.github/workflows/release.yml |
Refreshes images for PHP version detection and release builds. |
Review effort: Balanced
Author
|
I have read the CLA Document and I hereby sign the CLA |
mackrais
marked this pull request as ready for review
October 21, 2026 20:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always pull fresh PHP base images in release and test builds
to avoid reusing outdated cached images.
Validation: actionlint and git diff --check passed.
Fixes pimcore/platform-version#674